feat(client): report-picker art thumbnails, zone filter, and debug i18n#5166
Merged
Conversation
Card-report picker polish, all composed from existing building blocks: - Per-row art thumbnail (art_crop via cardImageLookup + useCardImage) that opens the board's full card preview on hover / touch long-press through useCardHover; the row's tap-to-confirm is gated on firedRef so previewing never fires a report. cardImageLookup already handles emblems, tokens, MDFCs, and transformed faces, so no special-casing. - Zone filter chips mirroring the player filter: zones recorded before any filter is applied so a selection never hides the other chips; the shared chip is generalized from PlayerFilterChip to FilterChip. New cardReport. allZones key across all 7 locales. - Debug panel's player-facing 'report a card' section now uses i18n (help.reportCardNudge.debugPrompt + reused open) instead of hardcoded English. New debugPrompt key across all 7 locales.
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card-report picker polish, all composed from existing building blocks:
opens the board's full card preview on hover / touch long-press through
useCardHover; the row's tap-to-confirm is gated on firedRef so previewing
never fires a report. cardImageLookup already handles emblems, tokens,
MDFCs, and transformed faces, so no special-casing.
filter is applied so a selection never hides the other chips; the shared
chip is generalized from PlayerFilterChip to FilterChip. New cardReport.
allZones key across all 7 locales.
(help.reportCardNudge.debugPrompt + reused open) instead of hardcoded
English. New debugPrompt key across all 7 locales.