Skip to content

Fix board choice overlays and attack splitting#5344

Merged
matthewevans merged 1 commit into
mainfrom
ship/fix-board-choice-overlays-and-attack-splitting
Jul 7, 2026
Merged

Fix board choice overlays and attack splitting#5344
matthewevans merged 1 commit into
mainfrom
ship/fix-board-choice-overlays-and-attack-splitting

Conversation

@matthewevans

Copy link
Copy Markdown
Member

No description provided.

@matthewevans matthewevans enabled auto-merge July 7, 2026 22:35

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the collapsed group picker to render via a React Portal with dynamic positioning, and updates the attack target picker to distribute attackers globally when performing an even split. Additionally, it elevates the board layout's z-index when a board choice is active. Feedback highlights a potential issue where this elevated z-index (z-[45]) could obscure the reconnecting banner (z-40) during a disconnection, and suggests conditionally resetting the z-index when reconnecting.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread client/src/pages/GamePage.tsx Outdated
@matthewevans matthewevans added this pull request to the merge queue Jul 7, 2026
@matthewevans matthewevans removed this pull request from the merge queue due to a manual request Jul 7, 2026
@matthewevans matthewevans force-pushed the ship/fix-board-choice-overlays-and-attack-splitting branch from 897a813 to ccc4c88 Compare July 7, 2026 22:58
@matthewevans matthewevans enabled auto-merge July 7, 2026 22:58
@matthewevans matthewevans added this pull request to the merge queue Jul 7, 2026
Merged via the queue into main with commit 8d5cb36 Jul 7, 2026
13 checks passed
@matthewevans matthewevans deleted the ship/fix-board-choice-overlays-and-attack-splitting branch July 7, 2026 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant