test(parser): pin Violent Urge Delirium clause to ParentTarget (#1272)#5348
Merged
matthewevans merged 1 commit intoJul 8, 2026
Conversation
…-rs#1272) Investigated phase-rs#1272's "double strike grants to all creatures" report: already fixed generically by phase-rs#2999 (ParentTarget GenericEffect binding for targeted pump/debuff abilities, originally for Mu Yanling phase-rs#2922). Verified locally by parsing the real Oracle text and asserting the Delirium clause's static ability is scoped to ParentTarget, not an unscoped filter. Adds permanent regression coverage since neither card ever got a follow-up test after phase-rs#2999 landed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
matthewevans
approved these changes
Jul 8, 2026
matthewevans
left a comment
matthewevans
left a comment
Member
There was a problem hiding this comment.
Reviewed test-only parser coverage. Oracle text matches Scryfall, the assertion reaches the parser-produced GenericEffect/static grant shape, and the existing neighboring Delirium condition test covers the same card condition. Local diff is limited to oracle_tests.rs; no blocking review comments found.
matthewevans
added
test
Parse changes introduced by this PRBaseline pending for |
rykerwilliams
added a commit
to rykerwilliams/phase
that referenced
this pull request
Jul 8, 2026
Audited all four "already fixed" GitHub comments posted tonight, found real gaps where claims rested on a sub-agent's deleted scratch test rather than executed local verification, and fixed each one with a real permanent test (phase-rs#5348, phase-rs#5350, phase-rs#5351) plus updated comments. Logged as standing lesson 11 so this doesn't need re-litigating. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
main, no behavior change in this PR.TargetFilter::ParentTarget(the same single target as the base pump effect), not an unscoped/all-creatures filter.Test plan
violent_urge_delirium_scopes_to_parent_target_not_all_creaturespasses locally.🤖 Generated with Claude Code