Skip to content

fix(pr-review): include full review metadata in scan#5373

Merged
matthewevans merged 1 commit into
mainfrom
ship/pr-review-scan-review-metadata
Jul 8, 2026
Merged

fix(pr-review): include full review metadata in scan#5373
matthewevans merged 1 commit into
mainfrom
ship/pr-review-scan-review-metadata

Conversation

@matthewevans

Copy link
Copy Markdown
Member

No description provided.

@matthewevans matthewevans enabled auto-merge July 8, 2026 16:23

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates scripts/pr_review.py to set include_full_reviews to True in the GraphQL query fields. The reviewer notes that fetching full reviews during bulk scans could lead to GraphQL payload bloat and potential rate limits or timeouts, and recommends reverting this change.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread scripts/pr_review.py
+ pr_node_fields(
comments_last=15,
include_full_reviews=False,
include_full_reviews=True,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

[MED] GraphQL query payload bloat in bulk scan. Evidence: scripts/pr_review.py:2300.\n> Why it matters: Fetching up to 50 reviews for every open PR during a bulk scan significantly increases the GraphQL payload and execution time, risking rate limits or query timeouts on large repositories.\n> Suggested fix: Revert to include_full_reviews=False for the scan query and rely on the single-PR query's full fetch when acting on candidates.

Suggested change
include_full_reviews=True,
include_full_reviews=False,

@matthewevans matthewevans added this pull request to the merge queue Jul 8, 2026
Merged via the queue into main with commit a66594e Jul 8, 2026
13 checks passed
@matthewevans matthewevans deleted the ship/pr-review-scan-review-metadata branch July 8, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant