fix(client): scry/surveil dialog scrolls to reach all cards at large counts#5416
Merged
Conversation
…counts
The Reorder.Group combined justify-center and overflow-x-auto on one flex
element, so at large scry/surveil counts the leading cards were centered into
negative scroll space that scrollLeft (>= 0) can never reach — only the last
~20 cards were viewable. Separate centering from scrolling: an outer
overflow-x-auto container wraps a w-max mx-auto group (auto-centers when it
fits, collapses-and-stays-reachable when it overflows). Drag-reorder is
preserved (Reorder.Group stays the flex/drag parent). useHorizontalScroll is
parameterized {drag:false} for this framer-managed path (wheel kept, drag
suppressed to avoid fighting Reorder).
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Reorder.Group combined justify-center and overflow-x-auto on one flex
element, so at large scry/surveil counts the leading cards were centered into
negative scroll space that scrollLeft (>= 0) can never reach — only the last
~20 cards were viewable. Separate centering from scrolling: an outer
overflow-x-auto container wraps a w-max mx-auto group (auto-centers when it
fits, collapses-and-stays-reachable when it overflows). Drag-reorder is
preserved (Reorder.Group stays the flex/drag parent). useHorizontalScroll is
parameterized {drag:false} for this framer-managed path (wheel kept, drag
suppressed to avoid fighting Reorder).