fix(parser): recognize "transformed" as a filter quality (Mutagen Connoisseur)

[galuis116]

Closes #5439.

The bug

Mutagen Connoisseur — "This creature gets +1/+0 for each transformed permanent you control." — parsed to a flat AddPower{1}/AddToughness{0}. The "for each transformed permanent you control" scaling was silently dropped, so the card always gets +1/+0 instead of +N/+0. The parser's own swallow-audit flags a DynamicQty SwallowedClause on the line.

Root cause

Isolation shows only the transformed quality is affected — tapped, face-down, artifact, creature all scale correctly:

Phrase	Scales today
for each tapped permanent you control	✅
for each artifact you control	✅
for each transformed permanent you control	❌ (flat)

FilterProp has boolean battlefield-state qualities (Tapped, FaceDown, Suspected, IsSaddled, …) recognized as type-phrase adjective prefixes, but no Transformed variant — even though GameObject::transformed already exists.

Fix

Adds FilterProp::Transformed, the symmetric sibling of FilterProp::FaceDown — a per-object battlefield state read from GameObject::transformed:

• recognized as an adjective prefix (transformed permanent/transformed creature) via parse_property_filter + the parse_combat_status_prefix whitelist;
• matched at runtime in filter.rs (FilterProp::Transformed => obj.transformed);
• threaded through the axis-classification lists / coverage display alongside FaceDown.

No runtime state change — the object flag was already tracked; this only lets the parser build the count/selector that reads it. Consistent with the existing individual-variant design for boolean state qualities (Suspected, Renowned, IsSaddled were all added the same way), so no parameterization refactor is implied.

Tests

• test_parse_property_filter_transformed — "transformed permanent" → FilterProp::Transformed.
• transformed_property_matches_only_transformed — the filter matches a transformed permanent and rejects a normal one.

Verification

cargo fmt --all ✓ · engine lib suite 15,904 pass / 0 fail + 2 new ✓ · clippy -p engine --all-targets -D warnings clean ✓

CR 711.4.

[gemini-code-assist]

Code Review

This pull request implements the Transformed property filter across the engine and parser to support transformed permanents (with their back face up). The changes include updating FilterProp matching, adding parser support for the "transformed" adjective, and introducing corresponding unit tests. The review feedback correctly identifies multiple outdated Comprehensive Rules (CR) annotations referencing CR 711.4 instead of CR 701.28g, which violates the repository's strict rule-fidelity guidelines. These references should be updated to ensure accurate documentation.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

[github-actions]

Parse changes introduced by this PR · 4 card(s), 5 signature(s) (baseline: main 500e30b15742)

1 card(s) · static/Continuous · added: Continuous (affects=transformed another you control permanent, mods=grant Trample, grant Ward)

Examples: Gargantuan Slabhorn

1 card(s) · static/Continuous · field conditional: unrecognized → transformed in battlefield you control permanent is present

Examples: Oculus Whelp

1 card(s) · static/Continuous · field mods: power +1, toughness +0 → add dynamic power

Examples: Mutagen Connoisseur

1 card(s) · ability/TargetOnly · field target: any → transformed token you control Phyrexian

Examples: Incubation Triformer

1 card(s) · ability/static_structure · removed: static_structure

Examples: Gargantuan Slabhorn

[galuis116]

Good catch on the CR reference — fixed. CR 711 is indeed Leveler Cards, so CR 711.4 was wrong.

One correction to the suggestion: the bot proposed CR 701.28g, but CR 701.28 is Convert, not Transform. The definition of a "transformed permanent" is CR 701.27g:

701.27g Some spells and abilities refer to a "transformed permanent." This phrase refers to a double-faced permanent on the battlefield with its back face up. …

I've updated all six citations (code + tests + commit message) to CR 701.27g, which also matches the existing convention in the repo — FilterProp::SourceIsTransformed already cites CR 701.27g (types/ability.rs). Verified against docs/MagicCompRules.txt.

[matthewevans]

Implementation review remains clean at ac6cd6427541e0e65d3d1365d9534a81809f70e6. The change is at the shared FilterProp/typed-filter parser seam, uses the existing nom property combinator path, carries the verified CR 701.27g citation, and the refreshed parse-diff shows only the expected transformed-permanent class expansion.