Fix attack-event qualifier stack conditions#5455
Merged
matthewevans merged 1 commit intoJul 9, 2026
Merged
Conversation
matthewevans
enabled auto-merge
July 9, 2026 19:29
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new integration test suite, attack_qualifier_stack_conditions.rs, which verifies that event-only attack conditions are correctly checked when an attack event fires and then stripped from the stack entry. It also registers this new test module in main.rs. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Parse changes introduced by this PR✓ No card-parse changes detected. |
matthewevans
force-pushed
the
ship/fix-attack-event-qualifier-stack-conditions
branch
from
July 9, 2026 19:49
b9c10da to
b4f8b78
Compare
matthewevans
force-pushed
the
ship/fix-attack-event-qualifier-stack-conditions
branch
from
July 9, 2026 19:49
b4f8b78 to
af35ec9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.