docs(parser): correct CR 609.3 -> CR 603.5 on trigger optionality#5483
Merged
Conversation
CR 609.3 (docs/MagicCompRules.txt:2847) is "If an effect attempts to do something impossible, it does only as much as possible" -- unrelated to optionality. The rule governing "may" triggers is CR 603.5 (:2595): 603.5. Some triggered abilities' effects are optional (they contain "may," as in "At the beginning of your upkeep, you may draw a card"). These abilities go on the stack when they trigger, regardless of whether their controller intends to exercise the ability's option or not. The choice is made when the ability resolves. Fixes both sites that annotate trigger optionality: - oracle_ir/trigger.rs:53 TriggerModifiers.optional - oracle_trigger.rs:1289 propagation onto the execute ability Also corrects a stale comment naming Grenzo, Havoc Raiser as the canonical inline-modal-trigger card. Grenzo uses bullet-line modes (raw_modes.len() == 1) and cannot reach that branch; no printed card currently does. Comment-only. No behavior change.
matthewevans
enabled auto-merge
July 10, 2026 05:44
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Parse changes introduced by this PR✓ No card-parse changes detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CR 609.3 (docs/MagicCompRules.txt:2847) is "If an effect attempts to do
something impossible, it does only as much as possible" -- unrelated to
optionality. The rule governing "may" triggers is CR 603.5 (:2595):
603.5. Some triggered abilities' effects are optional (they contain
"may," as in "At the beginning of your upkeep, you may draw a card").
These abilities go on the stack when they trigger, regardless of
whether their controller intends to exercise the ability's option or
not. The choice is made when the ability resolves.
Fixes both sites that annotate trigger optionality:
Also corrects a stale comment naming Grenzo, Havoc Raiser as the
canonical inline-modal-trigger card. Grenzo uses bullet-line modes
(raw_modes.len() == 1) and cannot reach that branch; no printed card
currently does.
Comment-only. No behavior change.