fix(release): always build macOS Tauri, shipping an ad-hoc .dmg#5521
Merged
Conversation
The 'Check macOS signing secrets' gate set skip=true whenever any of the five APPLE_* secrets was missing, and every downstream step was gated on it — so with no Apple secrets configured the macOS leg did checkout + the check (~17s), skipped the build, and exited 'success'. No phase-tauri-macos artifact was ever produced, and the release published silently without a .dmg. tauri-action already adapts to whichever signing secrets are present (sign only if APPLE_CERTIFICATE/APPLE_SIGNING_IDENTITY set, notarize only if APPLE_ID/APPLE_PASSWORD/APPLE_TEAM_ID set), so the gate was redundant and harmful. Remove it and let the macOS leg always build: an ad-hoc, un-notarized .dmg today (users clear Gatekeeper via the xattr -cr line already documented in the release notes), and an automatically signed+notarized .dmg if the Apple secrets are ever added.
matthewevans
enabled auto-merge
July 10, 2026 18:52
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'Check macOS signing secrets' gate set skip=true whenever any of the
five APPLE_* secrets was missing, and every downstream step was gated on
it — so with no Apple secrets configured the macOS leg did checkout + the
check (~17s), skipped the build, and exited 'success'. No phase-tauri-macos
artifact was ever produced, and the release published silently without a
.dmg.
tauri-action already adapts to whichever signing secrets are present
(sign only if APPLE_CERTIFICATE/APPLE_SIGNING_IDENTITY set, notarize only
if APPLE_ID/APPLE_PASSWORD/APPLE_TEAM_ID set), so the gate was redundant
and harmful. Remove it and let the macOS leg always build: an ad-hoc,
un-notarized .dmg today (users clear Gatekeeper via the xattr -cr line
already documented in the release notes), and an automatically
signed+notarized .dmg if the Apple secrets are ever added.