feat(engine): add Witherbloom pre-cast shortcut#5759
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements a finite, pre-cast copy shortcut protocol for self-targeted Chain-shaped spells (such as Chain of Smog) combined with a fixed Magecraft drain observer (such as Witherbloom Apprentice). It introduces new WaitingFor and GameAction variants, updates the adapters and persistence layer to support a trusted game state envelope (PersistedGameState), adds dedicated UI modals, and integrates AI support and comprehensive tests. The review feedback highlights a critical ReferenceError in dispatch.ts where adapter is referenced without being destructured, points out redundant optional chaining on the guaranteed players property in GameProvider.tsx, and suggests documenting the COPY_COUNT constant in the new pre-cast shortcut module.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Parse changes introduced by this PR✓ No card-parse changes detected. |
No description provided.