Skip to content

feat(engine): add Witherbloom pre-cast shortcut#5759

Merged
matthewevans merged 15 commits into
mainfrom
ship/witherbloom-precast-shortcut
Jul 14, 2026
Merged

feat(engine): add Witherbloom pre-cast shortcut#5759
matthewevans merged 15 commits into
mainfrom
ship/witherbloom-precast-shortcut

Conversation

@matthewevans

Copy link
Copy Markdown
Member

No description provided.

@matthewevans
matthewevans enabled auto-merge July 13, 2026 20:40

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements a finite, pre-cast copy shortcut protocol for self-targeted Chain-shaped spells (such as Chain of Smog) combined with a fixed Magecraft drain observer (such as Witherbloom Apprentice). It introduces new WaitingFor and GameAction variants, updates the adapters and persistence layer to support a trusted game state envelope (PersistedGameState), adds dedicated UI modals, and integrates AI support and comprehensive tests. The review feedback highlights a critical ReferenceError in dispatch.ts where adapter is referenced without being destructured, points out redundant optional chaining on the guaranteed players property in GameProvider.tsx, and suggests documenting the COPY_COUNT constant in the new pre-cast shortcut module.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread client/src/game/dispatch.ts
Comment thread client/src/providers/GameProvider.tsx Outdated
Comment thread crates/engine/src/game/precast_copy_shortcut.rs
@github-actions

github-actions Bot commented Jul 13, 2026

Copy link
Copy Markdown

Parse changes introduced by this PR

✓ No card-parse changes detected.

@matthewevans
matthewevans added this pull request to the merge queue Jul 14, 2026
Merged via the queue into main with commit 367b93e Jul 14, 2026
17 checks passed
@matthewevans
matthewevans deleted the ship/witherbloom-precast-shortcut branch July 14, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant