Skip to content

test(engine): cover Bloodthirsty Tenacity loop#5766

Merged
matthewevans merged 1 commit into
phase-rs:mainfrom
mike-theDude:fix/issue-4787-bloodthirsty-tenacity-loop
Jul 14, 2026
Merged

test(engine): cover Bloodthirsty Tenacity loop#5766
matthewevans merged 1 commit into
phase-rs:mainfrom
mike-theDude:fix/issue-4787-bloodthirsty-tenacity-loop

Conversation

@mike-theDude

Copy link
Copy Markdown
Collaborator

Summary

Closes #4787

Validation

  • cargo fmt --all -- --check
  • cargo test -p engine drive_bloodthirsty_conqueror_enduring_tenacity_wins_live -- --nocapture
  • cargo clippy -p engine --tests -- -D warnings

QA

Final recommendation: SCOPE READY

Tilt was unavailable in the isolated worktree:
No tilt apiserver found: tilt-default

Used direct cargo fallback per repo policy. Full engine suite was not run.

Gate A

Gate A PASS head=ee3abc893aa72873f7d5db4f91470d15c74759e1 base=7e1ddc9b778c3c3bcfa9e56d1f726561225c099d

Anchored on

  • crates/engine/src/analysis/corpus_tests.rs:966 — existing targeted drain/refill loop witness for Sanguine Bond + Exquisite Blood.
  • crates/engine/src/analysis/corpus_tests.rs:974 — existing live-loop test structure using build_drain_board, seed_lifegain_cascade, drive_pass_priority, and first_gameover_beat.

CR annotations

No runtime rules logic changed; test-only regression guard.

Model: gpt-5
Thinking: high
Tier: Standard

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@github-actions

Copy link
Copy Markdown

Parse changes introduced by this PR

✓ No card-parse changes detected.

@mike-theDude mike-theDude added ai-contribution PR opened via docs/AI-CONTRIBUTOR.md flow needs-maintainer AI-contribution PR requires human triage (Non-dev track or unresolved gaps) labels Jul 13, 2026
@matthewevans matthewevans self-assigned this Jul 14, 2026

@matthewevans matthewevans left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED

🔴 Blocker

  • None.

🟡 Non-blocking

  • None.

✅ Clean

  • The exact reported card pair runs through the real pass-priority corpus pipeline, verifies the targeted trigger auto-resolves for the sole opponent, and requires an early game-over at 200 life; reverting the loop shortcut would fail this regression.
  • Current-head CI, including Rust lint/tests and card-data validation, is green; the parse-diff artifact reports no card-parse changes.

Recommendation: approve and enqueue as a high-value test regression.

@matthewevans matthewevans added test Add tests quality For high-quality minimal to no-churn PRs labels Jul 14, 2026
@matthewevans
matthewevans added this pull request to the merge queue Jul 14, 2026
@matthewevans matthewevans removed their assignment Jul 14, 2026
Merged via the queue into phase-rs:main with commit 6fed04b Jul 14, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-contribution PR opened via docs/AI-CONTRIBUTOR.md flow needs-maintainer AI-contribution PR requires human triage (Non-dev track or unresolved gaps) quality For high-quality minimal to no-churn PRs test Add tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bloodthirsty Conquerer x Enduring Tenacity Inifinite Loop — This loop isn't triggering for the easy runaway when combo…

3 participants