Skip to content

fix(ui): address gameplay qol review feedback#5832

Merged
matthewevans merged 1 commit into
mainfrom
ship/gameplay-qol-review-fixes
Jul 14, 2026
Merged

fix(ui): address gameplay qol review feedback#5832
matthewevans merged 1 commit into
mainfrom
ship/gameplay-qol-review-fixes

Conversation

@matthewevans

Copy link
Copy Markdown
Member

No description provided.

@matthewevans
matthewevans enabled auto-merge July 14, 2026 18:47

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a dedicated button on permanent cards with a single attachment to open the attachment fan directly without selecting the host card, complete with localization and unit tests. Additionally, it refactors the ManaAnyCombinationChoiceModal component to deduplicate mana color options using useMemo, ensuring that duplicate mana colors in a prompt do not result in duplicate UI elements or incorrect selection counts, supported by a new unit test. No review comments were provided, and the changes conform to the repository's architectural guidelines.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@matthewevans
matthewevans disabled auto-merge July 14, 2026 19:02
@matthewevans
matthewevans merged commit 1c01ff4 into main Jul 14, 2026
13 checks passed
@matthewevans
matthewevans deleted the ship/gameplay-qol-review-fixes branch July 14, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant