Skip to content

ship/t165 rules special exemptions#6086

Merged
matthewevans merged 2 commits into
mainfrom
ship/t165-rules-special-exemptions
Jul 17, 2026
Merged

ship/t165 rules special exemptions#6086
matthewevans merged 2 commits into
mainfrom
ship/t165-rules-special-exemptions

Conversation

@matthewevans

Copy link
Copy Markdown
Member
  • chore(engine): classify the rules/special zone-census tranche with reviewed exemptions
  • chore(engine): refresh zone-authority baseline after rules/special exemptions (43 hits / 29 rows)

…viewed exemptions

Annotation-only pass over the 24 remaining non-exempt zone-authority
census rows. Eighteen rows are not CR zone-change events and receive
`allow-raw-zone` exemptions with grep-verified CR citations:

- Variant/supplementary-deck bookkeeping: scheme cards remain in the
  command zone throughout the game (CR 314.2 + CR 904.4), planar cards
  likewise (CR 901.4; CR 901.5/901.10 procedures), pregame conspiracy
  setup starts outside the game which is not a zone (CR 400.11 +
  CR 905.4), attraction/contraption/planar/scheme deck loading is object
  birth into command-zone bookkeeping (CR 717.2, CR 701.45a, CR 901.4,
  CR 314.2), and archenemy teardown on player-leave is the CR 800.4a
  leave-game procedure.
- Copy synthesis: spell copies are created directly on the stack (or in
  exile for prepared copies) with no from-zone event (CR 707.10 /
  CR 707.12).
- Liminal token finalization is object birth whose entry replacements
  were already consulted by ProposedEvent::TokenEntry (CR 111.2 +
  CR 614.12); debug RemoveObject is forced state deletion, not a rules
  event (CR 400.1).

Six rows are genuine CR zone-change events that bypass the
replacement-safe pipeline and are deliberately NOT annotated — they stay
red in the census as chartered migration follow-ups: cascade's
library exile loop (CR 702.85a), cast-from-zone's pre-permission exile,
cloak's battlefield exile leg (CR 701.58a), explore's land-to-hand leg
(CR 701.44a), return-as-aura's no-target fallback (CR 303.4g), and the
commander return arm (CR 903.9a).

Census keeps all 43 hits; 22 reclassify into the ratcheted `exempt`
family (rows 32 -> 29 by family aggregation). Baseline tightened
accordingly. No behavior change; comment-only diff.
@matthewevans
matthewevans enabled auto-merge July 17, 2026 10:14

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds allow-raw-zone documentation comments across various game engine files (such as archenemy.rs, conspiracy.rs, deck_loading.rs, and others) to justify raw zone modifications with references to the Magic Comprehensive Rules (CR). Symmetrically, it updates the scripts/zone-authority-baseline.txt file to mark these locations as exempt instead of container, zone-assign, or mover. There are no review comments to evaluate, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@matthewevans
matthewevans added this pull request to the merge queue Jul 17, 2026
@github-actions

Copy link
Copy Markdown

Parse changes introduced by this PR

✓ No card-parse changes detected.

Merged via the queue into main with commit 68eab04 Jul 17, 2026
13 checks passed
@matthewevans
matthewevans deleted the ship/t165-rules-special-exemptions branch July 17, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant