Skip to content

fix(menu): avoid WebKit button paint layer#6547

Merged
matthewevans merged 1 commit into
mainfrom
fix/dashboard-active-deck-surface
Jul 23, 2026
Merged

fix(menu): avoid WebKit button paint layer#6547
matthewevans merged 1 commit into
mainfrom
fix/dashboard-active-deck-surface

Conversation

@matthewevans

@matthewevans matthewevans commented Jul 23, 2026

Copy link
Copy Markdown
Member

Summary\n- render the active-deck card with the keyboard-accessible card-tile pattern instead of a native button\n- avoid the WebKit/Tauri native button paint-layer issue that hid its art header\n\n## Verification\n- \n- verified visually in the local Tilt Tauri app with a deck containing Lightning Bolt art\n\nCloses #6537

Summary by CodeRabbit

  • Accessibility
    • Improved keyboard accessibility for the active deck card.
    • Added support for activating the card with Enter or Space.
  • UI Improvements
    • Updated the card’s interactive styling and layout behavior.

@matthewevans
matthewevans enabled auto-merge July 23, 2026 15:30
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f9abe718-b5fe-4075-91d6-9da2ee62a74e

📥 Commits

Reviewing files that changed from the base of the PR and between c754a08 and c2a26a3.

📒 Files selected for processing (1)
  • client/src/components/menu/home/HomeDashboard.tsx

📝 Walkthrough

Walkthrough

The active deck card replaces its native button wrapper with an accessible div, adds Enter and Space keyboard handling, updates container classes, and simplifies art-header layering for WebKit rendering.

Changes

Active deck rendering

Layer / File(s) Summary
Accessible active deck card
client/src/components/menu/home/HomeDashboard.tsx
The active deck wrapper uses role="button" and tabIndex, handles Enter and Space navigation to /my-decks, updates its classes, and simplifies art-header positioning styles.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is specific and matches the main change: swapping the active-deck button rendering to avoid the WebKit paint-layer issue.
Linked Issues check ✅ Passed The code change removes the native button wrapper and adjusts the card styling, aligning with #6537's WebKit rendering fix.
Out of Scope Changes check ✅ Passed The PR stays focused on the active-deck card WebKit fix and does not introduce unrelated changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/dashboard-active-deck-surface

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans added this pull request to the merge queue Jul 23, 2026
Merged via the queue into main with commit 95ecfb2 Jul 23, 2026
15 checks passed
@matthewevans
matthewevans deleted the fix/dashboard-active-deck-surface branch July 23, 2026 16:09
jsdevninja pushed a commit to jsdevninja/phase that referenced this pull request Jul 24, 2026
Co-authored-by: matthewevans <matthewevans@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant