Skip to content

policy(pr-review): revert skip-to-close-on-sight; gate closures on diff evidence#6583

Merged
matthewevans merged 1 commit into
mainfrom
ship/pr-review-skip-close-on-sight-revert
Jul 24, 2026
Merged

policy(pr-review): revert skip-to-close-on-sight; gate closures on diff evidence#6583
matthewevans merged 1 commit into
mainfrom
ship/pr-review-skip-close-on-sight-revert

Conversation

@matthewevans

Copy link
Copy Markdown
Member

The skip route was changed on 2026-07-24 to mean "close on sight" as part
of a contributor ban. That ban was reversed: the trigger was
Co-Authored-By: Claude Haiku 4.5 trailers, but claude-haiku-4-5 was
named in the accepted Standard row of the tier table live at the time, and
the Frontier-only rule landed at 2026-07-24T02:03:45Z — after the newest
affected PR was opened at 2026-07-23T22:09:07Z. The enforcement was
retroactive.

The close-on-sight text outlived the ban in this tracked skill, so a future
sweep would have re-applied it to every skip login — including dale053,
which was set for an unrelated reason and never carried that action.

  • skip returns to decline-to-review; it does not authorize closing.
  • Drop the "a prior approval is not evidence" paragraph. It was written to
    justify dequeuing two PRs this maintainer had approved at unchanged heads,
    and it generalizes into distrusting our own review record.
  • Add the low-effort close rule, scoped to any author and to diff-visible
    evidence only, with the requirement to re-verify that evidence firsthand
    rather than inheriting an earlier review's summary.
  • Add the policy-date rule: git log the policy doc and diff the version live
    at the PR's createdAt before enforcing against it.
  • Record that a Co-Authored-By trailer names the model for one commit, so
    trailers are read against the implementing commits; a mid-run fallback
    leaves sub-floor trailers on a compliant change.

…ff evidence

The `skip` route was changed on 2026-07-24 to mean "close on sight" as part
of a contributor ban. That ban was reversed: the trigger was
`Co-Authored-By: Claude Haiku 4.5` trailers, but `claude-haiku-4-5` was
named in the accepted Standard row of the tier table live at the time, and
the Frontier-only rule landed at 2026-07-24T02:03:45Z — after the newest
affected PR was opened at 2026-07-23T22:09:07Z. The enforcement was
retroactive.

The close-on-sight text outlived the ban in this tracked skill, so a future
sweep would have re-applied it to every `skip` login — including `dale053`,
which was set for an unrelated reason and never carried that action.

- `skip` returns to decline-to-review; it does not authorize closing.
- Drop the "a prior approval is not evidence" paragraph. It was written to
  justify dequeuing two PRs this maintainer had approved at unchanged heads,
  and it generalizes into distrusting our own review record.
- Add the low-effort close rule, scoped to any author and to diff-visible
  evidence only, with the requirement to re-verify that evidence firsthand
  rather than inheriting an earlier review's summary.
- Add the policy-date rule: git log the policy doc and diff the version live
  at the PR's createdAt before enforcing against it.
- Record that a Co-Authored-By trailer names the model for one commit, so
  trailers are read against the implementing commits; a mid-run fallback
  leaves sub-floor trailers on a compliant change.
@matthewevans
matthewevans enabled auto-merge July 24, 2026 03:40
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@matthewevans, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 seconds

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9edbb617-2785-4ca1-bd5f-649733d791f4

📥 Commits

Reviewing files that changed from the base of the PR and between 7de942f and 2e9ea38.

📒 Files selected for processing (1)
  • .claude/skills/pr-review-loop/SKILL.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ship/pr-review-skip-close-on-sight-revert

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit ea60d3e Jul 24, 2026
14 checks passed
@matthewevans
matthewevans deleted the ship/pr-review-skip-close-on-sight-revert branch July 24, 2026 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant