Skip to content

fix(native-engine): suppress Windows console window when spawning phase-server#6597

Merged
matthewevans merged 1 commit into
mainfrom
ship/suppress-windows-console-window
Jul 24, 2026
Merged

fix(native-engine): suppress Windows console window when spawning phase-server#6597
matthewevans merged 1 commit into
mainfrom
ship/suppress-windows-console-window

Conversation

@matthewevans

@matthewevans matthewevans commented Jul 24, 2026

Copy link
Copy Markdown
Member

The desktop shell is a GUI-subsystem app but phase-server.exe is
console-subsystem, so Windows allocated a visible console window for the
child on every launch. Apply the CREATE_NO_WINDOW creation flag on all
three Windows console spawns: the phase-server launch (the persistent
window), plus the tasklist stale-process probe and taskkill cleanup
(each of which briefly flashed its own console).

Summary by CodeRabbit

  • Bug Fixes
    • Prevented unwanted console windows from appearing when starting and stopping the native service on Windows.
    • Improved the background process experience during shutdown and process checks without changing existing functionality.

…se-server

The desktop shell is a GUI-subsystem app but phase-server.exe is
console-subsystem, so Windows allocated a visible console window for the
child on every launch. Apply the CREATE_NO_WINDOW creation flag on all
three Windows console spawns: the phase-server launch (the persistent
window), plus the tasklist stale-process probe and taskkill cleanup
(each of which briefly flashed its own console).
@matthewevans
matthewevans enabled auto-merge July 24, 2026 16:06
@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 91cbd7df-f7aa-49bc-8dec-a3e81e8b05ca

📥 Commits

Reviewing files that changed from the base of the PR and between 6895ca3 and c29fce1.

📒 Files selected for processing (1)
  • client/src-tauri/src/native_engine.rs

📝 Walkthrough

Walkthrough

Windows process creation is updated to suppress console windows for the native phase-server, shutdown taskkill, and identity-check tasklist commands while preserving existing arguments, environment, and error handling.

Changes

Windows process console suppression

Layer / File(s) Summary
Apply Windows no-window flags
client/src-tauri/src/native_engine.rs
Adds the Windows command extension and CREATE_NO_WINDOW, refactors server command construction to apply the flag before spawning, and applies it to Windows taskkill and tasklist invocations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: suppressing the Windows console window for native-engine process spawning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ship/suppress-windows-console-window

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit 2cdb2b8 Jul 24, 2026
15 checks passed
@matthewevans
matthewevans deleted the ship/suppress-windows-console-window branch July 24, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant