fix(native-engine): suppress Windows console window when spawning phase-server#6597
Merged
Merged
Conversation
…se-server The desktop shell is a GUI-subsystem app but phase-server.exe is console-subsystem, so Windows allocated a visible console window for the child on every launch. Apply the CREATE_NO_WINDOW creation flag on all three Windows console spawns: the phase-server launch (the persistent window), plus the tasklist stale-process probe and taskkill cleanup (each of which briefly flashed its own console).
matthewevans
enabled auto-merge
July 24, 2026 16:06
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughWindows process creation is updated to suppress console windows for the native ChangesWindows process console suppression
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop shell is a GUI-subsystem app but phase-server.exe is
console-subsystem, so Windows allocated a visible console window for the
child on every launch. Apply the CREATE_NO_WINDOW creation flag on all
three Windows console spawns: the phase-server launch (the persistent
window), plus the tasklist stale-process probe and taskkill cleanup
(each of which briefly flashed its own console).
Summary by CodeRabbit