feat: show temporary unblockable effects#6611
Conversation
|
Warning Review limit reached
Next review available in: 19 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesThe engine now projects active until-end-of-turn Temporary unblockability
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant GameState
participant DerivedViews
participant ClientAdapter
participant PermanentCard
GameState->>DerivedViews: derive temporary CantBeBlocked grants
DerivedViews->>ClientAdapter: publish recipient and optional source IDs
ClientAdapter->>PermanentCard: provide derived marker
PermanentCard->>PermanentCard: resolve source name and render badge
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@client/src/components/board/__tests__/PermanentCard.test.tsx`:
- Around line 233-240: Add a positive reach guard in the test case “does not
render a temporary can't-be-blocked badge without an engine marker” by asserting
the rendered PermanentCard’s stable [data-object-id="1"] element is present
before checking that the “Can't be blocked” badge is absent.
- Around line 210-218: Update the test case for the temporary can't-be-blocked
badge to interact with the badge trigger—by hovering or focusing the element
labeled “Can't be blocked”—before asserting the “(from Test Equipment)” tooltip
text. Verify the tooltip is visible after opening it rather than merely present
in the portal.
In `@client/src/components/board/PermanentCard.tsx`:
- Around line 143-154: Update CantBeBlockedBadge in PermanentCard so it does not
occupy the existing bottom-left badge slot used by Ring Bearer and class-level
indicators. Reuse the shared overlay stack if available, or assign a
non-overlapping position that preserves visibility of all coexisting badges.
In `@crates/engine/tests/integration/temporary_cant_be_blocked_view.rs`:
- Around line 44-89: Add a positive reach guard for permanent_recipient after
evaluate_layers, confirming its static_definitions contains the permanent
CantBeBlocked mode before the negative temporary_cant_be_blocked assertion. Keep
the existing recipient guard and ensure the new assertion verifies the
Duration::Permanent grant reached the evaluated state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d8dd693f-97eb-4c01-8084-49cd4cc5b4e8
📒 Files selected for processing (13)
client/src/adapter/types.tsclient/src/components/board/PermanentCard.tsxclient/src/components/board/__tests__/PermanentCard.test.tsxclient/src/i18n/locales/de/game.jsonclient/src/i18n/locales/en/game.jsonclient/src/i18n/locales/es/game.jsonclient/src/i18n/locales/fr/game.jsonclient/src/i18n/locales/it/game.jsonclient/src/i18n/locales/pl/game.jsonclient/src/i18n/locales/pt/game.jsoncrates/engine/src/game/derived_views.rscrates/engine/tests/integration/main.rscrates/engine/tests/integration/temporary_cant_be_blocked_view.rs
Parse changes introduced by this PR✓ No card-parse changes detected. |
Summary by CodeRabbit