fix(client): honor private LobbyOnly hosts (#6556)

[matthewevans]

Summary by CodeRabbit

• Bug Fixes
  • Corrected broker-based peer-to-peer hosting visibility settings.
  • Private hosting sessions are now properly marked as private throughout setup and broker registration.
  • Added coverage to verify both public and private hosting options.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 17063f26-eb7f-4bfd-b3d3-9e48fbacfab8

📥 Commits

Reviewing files that changed from the base of the PR and between b9238c8 and 5d53d00.

📒 Files selected for processing (2)

• client/src/stores/__tests__/multiplayerStore.test.ts
• client/src/stores/multiplayerStore.ts

---

📝 Walkthrough

Walkthrough

Broker-backed P2P hosting now respects the configured public visibility in store state and broker registration. Tests add broker-client mocks and verify both public and private hosting settings.

Changes

Broker host visibility

Layer / File(s)	Summary
Apply configured host visibility client/src/stores/multiplayerStore.ts	startP2PHostingSession uses settings.public for initial state, broker registration, and the waiting state.
Mock and test broker visibility client/src/stores/__tests__/multiplayerStore.test.ts	Broker client methods are mocked, and parameterized tests verify public and private registration values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• phase-rs/phase#6595: Changes related broker-based hosting visibility and corresponding multiplayer store tests.

Suggested reviewers: davidomil, parthmishra

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: honoring private LobbyOnly hosts in client broker-backed hosting.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ship/fix-client-private-lobbyonly-hosts-6556

---

_{Comment @coderabbitai help to get the list of available commands.}