fix(client): expose targetable attachments

[matthewevans]

Summary by CodeRabbit

• Bug Fixes
  • Improved attachment targeting on cards.
  • Clicking a card with actionable attachments now opens the attachment chooser, allowing users to select the intended attached card.
  • Selecting an attached card correctly proceeds with target selection.

[coderabbitai]

📝 Walkthrough

Walkthrough

PermanentCard now opens the attachment chooser when attached permanents are actionable, reuses a dedicated chooser callback, and tests target selection through the attachment fan.

Changes

Attachment targeting

Layer / File(s)	Summary
Attachment chooser and target selection client/src/components/board/PermanentCard.tsx, client/src/components/board/__tests__/PermanentCard.test.tsx	PermanentCard centralizes attachment fan opening and invokes it for actionable attachments; the test verifies that selecting a targetable attachment dispatches ChooseTarget with its object ID.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: bug

Suggested reviewers: lgray

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the change: client behavior now exposes targetable attachments through the attachment fan.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ship/expose-targetable-attachments

---

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@client/src/components/board/PermanentCard.tsx`:
- Around line 692-697: Move attachment interaction determination out of the
client: replace the client-derived attachmentsActionable routing around
showAttachmentFan with engine-provided, host-scoped interaction options and
actions. Propagate these options/actions through every adapter to AttachmentFan,
and have the fan render only engine-authorized choices and dispatch their
corresponding actions, including sacrifice, mana-cost, and undo-tap states.
Remove client-side game-data derivation so the frontend remains a display layer.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d3c6690f-5b53-4156-86a2-2072b8c58348

📥 Commits

Reviewing files that changed from the base of the PR and between de8dc15 and b71afd5.

📒 Files selected for processing (2)

• client/src/components/board/PermanentCard.tsx
• client/src/components/board/__tests__/PermanentCard.test.tsx

[coderabbitai]

🎯 Functional Correctness | 🟠 Major | 🏗️ Heavy lift

Move attachment actionability and actions into the engine.

Line 692 makes a client-derived attachmentsActionable predicate control gameplay routing. It also includes sacrifice, mana-cost, and undo-tap states, but AttachmentFan only handles target selection, board choices, and activation actions—so those cases open a fan where selecting the attachment performs no action. Expose engine-authorized attachment interaction options/actions per host, wire them through every adapter, and have the fan render and dispatch that state.

As per path instructions, “The frontend is a display layer, never a logic layer” and game-data derivation must be pushed into the engine.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@client/src/components/board/PermanentCard.tsx` around lines 692 - 697, Move
attachment interaction determination out of the client: replace the
client-derived attachmentsActionable routing around showAttachmentFan with
engine-provided, host-scoped interaction options and actions. Propagate these
options/actions through every adapter to AttachmentFan, and have the fan render
only engine-authorized choices and dispatch their corresponding actions,
including sacrifice, mana-cost, and undo-tap states. Remove client-side
game-data derivation so the frontend remains a display layer.

Source: Path instructions