refactor(parser): emit priority spell router as native ir

[matthewevans]

Summary

• migrate priority spell routing to native AbilityIr with ordered root transforms
• retain inline spell and activated die-result tables without changing trigger terminal-roll behavior
• preserve compatibility lowerings while removing obsolete spell-router shims

Verification

• parser focused snapshots: 130 passed
• strict clippy: cargo clippy -p phase-engine --all-targets -- -D warnings
• Gates P/G/A passed
• independent review completed
• full-pool export: byte-identical to base and C1 (b24bc943a3b1…, 99,208,311 bytes)

Summary by CodeRabbit

• Bug Fixes
  • Improved Oracle rules parsing for “instead” effects, replacements, and overrides, including complex multiline and unbindable conditions.
  • Corrected die-result table association so results attach to the appropriate roll and are not consumed by unrelated text.
  • Improved handling of Priority 9 spell text, including voting, separate piles, descriptions, and minimum-value rules.
  • Improved parsing of Dig alternatives and trigger-based abilities.
• Tests
  • Added coverage for replacement behavior, spell structures, and die-result table edge cases.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5ef0830e-7968-4fcb-9098-8af3bc487460

📥 Commits

Reviewing files that changed from the base of the PR and between bbb176e and 00e25bc.

⛔ Files ignored due to path filters (44)

• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__aangs_journey_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__aerial_formation_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__aetherling_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__analyze_the_pollen_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__arni_brokenbrow_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__barbarian_ring_activated_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__batterskull_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__birds_of_paradise_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__blunt_the_assault_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__bomat_courier_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__bone_splinters_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__boseiju_who_endures_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__browbeat_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__carbonize_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__case_of_the_stashed_skeleton_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__champions_victory_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__component_pouch_activated_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__deadly_rollick_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__dismember_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__evils_thrall_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__experiment_one_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__figure_of_destiny_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__fog_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__follow_the_lumarets_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__ghost_lit_stalker_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__govern_the_guildless_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__guul_draz_assassin_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__incinerate_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__jade_mage_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__joraga_treespeaker_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__liliana_the_repentant_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__llanowar_elves_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__manamorphose_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__mother_of_runes_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__questing_beast_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__repeat_offender_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__stoneforge_mystic_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__swords_to_plowshares_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__sylvan_safekeeper_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__thespians_stage_generic_activated_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__touch_of_the_void_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__village_rites_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__vines_of_vastwood_ir.snap is excluded by !**/*.snap, !**/snapshots/**
• crates/engine/src/parser/oracle_ir/snapshots/engine__parser__oracle_ir__snapshot_tests__walking_ballista_ir.snap is excluded by !**/*.snap, !**/snapshots/**

📒 Files selected for processing (10)

• crates/engine/src/parser/oracle.rs
• crates/engine/src/parser/oracle_class.rs
• crates/engine/src/parser/oracle_effect/conditions.rs
• crates/engine/src/parser/oracle_effect/mod.rs
• crates/engine/src/parser/oracle_ir/effect_chain.rs
• crates/engine/src/parser/oracle_ir/snapshot_tests.rs
• crates/engine/src/parser/oracle_ir/trigger.rs
• crates/engine/src/parser/oracle_separate_piles.rs
• crates/engine/src/parser/oracle_special.rs
• crates/engine/src/parser/oracle_trigger.rs

---

📝 Walkthrough

Walkthrough

Oracle parsing now routes spell, replacement, condition, and die-result semantics through AbilityIr root transforms and IR-aware lowering. Result-table ownership distinguishes eligible roll-die nodes, while tests cover native spell nodes, residual replacements, and inline typed die tables.

Changes

Oracle IR pipeline

Layer / File(s)	Summary
Root-transform lowering crates/engine/src/parser/oracle_ir/effect_chain.rs, crates/engine/src/parser/oracle_effect/mod.rs, crates/engine/src/parser/oracle_effect/conditions.rs, crates/engine/src/parser/oracle_class.rs, crates/engine/src/parser/oracle_ir/trigger.rs, crates/engine/src/parser/oracle_separate_piles.rs	AbilityIr now stores ordered root transforms for field updates, condition composition, and residual replacement lowering; pile and dig parsing use IR entry points.
Spell and replacement routing crates/engine/src/parser/oracle.rs	Priority 9 spell branches and cross-line self-replacements now remain in IR longer, use root transforms, and capture emitted override item IDs.
Die-result ownership routing crates/engine/src/parser/oracle.rs, crates/engine/src/parser/oracle_special.rs, crates/engine/src/parser/oracle_trigger.rs	Die-result consumption checks IR roll-die structure and separates result-table attachment from terminal-roll attachment.
IR entry points and regression coverage crates/engine/src/parser/oracle_ir/snapshot_tests.rs, crates/engine/src/parser/oracle_separate_piles.rs	Tests cover native priority 9 nodes, replacement residuals, preserved metadata, and typed inline die-result tables.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant OracleParser
  participant AbilityIr
  participant lower_ability_ir
  participant AbilityDefinition
  OracleParser->>AbilityIr: parse spell or replacement
  AbilityIr->>lower_ability_ir: lower effect chain and root transforms
  lower_ability_ir->>AbilityDefinition: apply conditions, metadata, and residual policy
  OracleParser->>AbilityDefinition: attach eligible die-result branches

Loading

Possibly related PRs

• phase-rs/phase#6742: Refactors die-result handling through the same Oracle IR and lowering pipeline.
• phase-rs/phase#6748: Overlaps with cross-line instead self-replacement handling.
• phase-rs/phase#6792: Overlaps with activated-ability IR routing and die-result detection.

Suggested labels: quality

Suggested reviewers: dripsmvcp, invalidcards, jsdevninja

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: refactoring the parser to emit the priority spell router as native IR.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ship/inline-spell-die-result-tables

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.45.0)

crates/engine/src/parser/oracle_effect/mod.rs

ast-grep timed out on this file

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

Parse changes introduced by this PR

✓ No card-parse changes detected.