chore: refresh metagame feeds - #6810
Merged
Merged
Conversation
matthewevans
enabled auto-merge
July 30, 2026 08:27
Contributor
📝 WalkthroughWalkthroughThe MTGGoldfish feeds receive daily timestamp updates. Commander deck data is substantially regenerated, Codsworth entries are adjusted, and the Modern deck list replaces Boros Ponza with Neobrand. ChangesMTGGoldfish feed refresh
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@client/public/feeds/mtggoldfish-commander.json`:
- Around line 2470-2473: Normalize the Muldrotha, the Gravetide deck entry in
client/public/feeds/mtggoldfish-commander.json: set its colors to ["B","U","G"]
at lines 2470-2473, and clean every card name in lines 2478-2805 by removing
[SET], <collector>/<precon>/UUID, and (F) annotations so names resolve normally.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e7602767-7994-47f8-b90d-d651c1a4d96f
📒 Files selected for processing (4)
client/public/feeds/mtggoldfish-commander.jsonclient/public/feeds/mtggoldfish-modern.jsonclient/public/feeds/mtggoldfish-pioneer.jsonclient/public/feeds/mtggoldfish-standard.json
Comment on lines
+2470
to
+2473
| { | ||
| "name": "Muldrotha, the Gravetide", | ||
| "author": "MTGGoldfish", | ||
| "colors": [], |
Contributor
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
The "Muldrotha, the Gravetide" deck was ingested in an unnormalized format. Unlike every other deck in this feed, this one entry has an empty colors array and carries raw decklist-export annotations on every card name — both symptoms of the scraper writing this deck through a path that skips name/color normalization. validateFeed in client/src/services/feedService.ts accepts it (non-empty strings, colors is an array), so the breakage surfaces only at card-lookup time.
client/public/feeds/mtggoldfish-commander.json#L2470-L2473: populatecolorswith Muldrotha's["B","U","G"]identity instead of[].client/public/feeds/mtggoldfish-commander.json#L2478-L2805: strip[SET],<collector>/<precon>/UUID, and(F)suffixes from everynameso cards resolve and commander inference matches"Muldrotha, the Gravetide".
📍 Affects 1 file
client/public/feeds/mtggoldfish-commander.json#L2470-L2473(this comment)client/public/feeds/mtggoldfish-commander.json#L2478-L2805
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@client/public/feeds/mtggoldfish-commander.json` around lines 2470 - 2473,
Normalize the Muldrotha, the Gravetide deck entry in
client/public/feeds/mtggoldfish-commander.json: set its colors to ["B","U","G"]
at lines 2470-2473, and clean every card name in lines 2478-2805 by removing
[SET], <collector>/<precon>/UUID, and (F) annotations so names resolve normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated daily metagame feed refresh from MTGGoldfish.
Summary by CodeRabbit