Skip to content

fix(wasm): preserve simultaneous AI proposals - #6830

Merged
matthewevans merged 1 commit into
mainfrom
ship/ai-proposal-owner-scope
Jul 31, 2026
Merged

fix(wasm): preserve simultaneous AI proposals#6830
matthewevans merged 1 commit into
mainfrom
ship/ai-proposal-owner-scope

Conversation

@matthewevans

@matthewevans matthewevans commented Jul 31, 2026

Copy link
Copy Markdown
Member

Preserves one bounded proposal token per semantic owner so simultaneous mulligan decisions cannot invalidate one another. A successful interaction still invalidates every token because the state revision changes.

Summary by CodeRabbit

  • Bug Fixes
    • Improved simultaneous proposal handling so concurrent proposals from different owners are preserved.
    • Ensured each owner retains only one active proposal token.
    • Updated mulligan handling to support independent proposals and successful submission.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 76fe423e-6a93-4f2b-9179-b530edc61cef

📥 Commits

Reviewing files that changed from the base of the PR and between e6c6bb0 and 7ee00dd.

📒 Files selected for processing (1)
  • crates/engine-wasm/src/lib.rs

📝 Walkthrough

Walkthrough

AI proposal insertion now replaces only proposals for the same semantic owner. Concurrent proposals for different owners remain available. The simultaneous-mulligan test verifies proposal retention and successful application.

Changes

AI proposal ownership

Layer / File(s) Summary
Owner-scoped replacement and concurrent mulligan validation
crates/engine-wasm/src/lib.rs
AiProposalRegistry::insert retains proposals for different semantic owners while superseding the incoming owner’s prior proposal. The simultaneous-mulligan test verifies that both owners’ proposals remain live and that the first owner’s proposal applies successfully.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mike-thedude, parthmishra, davion-knight

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the change to preserve simultaneous AI proposals in WASM.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ship/ai-proposal-owner-scope

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans added this pull request to the merge queue Jul 31, 2026
Merged via the queue into main with commit 73fd7f6 Jul 31, 2026
15 checks passed
@matthewevans
matthewevans deleted the ship/ai-proposal-owner-scope branch July 31, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant