chore(agents): clarify post-acceptance PR handoff

[matthewevans]

Summary by CodeRabbit

• Documentation
  • Added guidance for post-acceptance pull request handoffs.
  • Clarified how to report branch-head status and review evidence after acceptance.
  • Documented that the handoff information does not introduce additional pipeline or automation requirements.

[coderabbitai]

📝 Walkthrough

Walkthrough

The engine implementer skill now documents post-acceptance PR handoff rules. It separates immutable acceptance evidence from mutable branch-head status and defines when to update or reset review evidence.

Changes

Post-acceptance PR handoff

Layer / File(s)	Summary
Document post-acceptance handoff rules .claude/skills/engine-implementer/SKILL.md	Defines the immutable accepted-candidate snapshot, branch-head status updates, review evidence reset rules, full-head review requirements, and non-gating handoff behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

• phase-rs/phase#6931: Both PRs modify .claude/skills/engine-implementer/SKILL.md with candidate-SHA and post-acceptance status guidance.

Suggested reviewers: lgray

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the added post-acceptance PR handoff clarification.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch ship/clarify-post-acceptance-pr-handoff

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.claude/skills/engine-implementer/SKILL.md:
- Around line 134-136: Before emitting the immutable Final Report snapshot in
the Post-acceptance PR handoff, verify that the actual branch ref backing the PR
still points to CANDIDATE_SHA, in addition to the existing
IMPLEMENTATION_WORKTREE HEAD check. Record the equality only when both
references match the accepted candidate, preserving the existing snapshot and
receipt evidence behavior.

🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b167c9e-db05-468f-b34b-79f1cb042b71

📥 Commits

Reviewing files that changed from the base of the PR and between 8b46e25 and 33b3f3b.

📒 Files selected for processing (1)

• .claude/skills/engine-implementer/SKILL.md

[coderabbitai]

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Verify the PR head before recording the accepted snapshot.

Line 132 verifies only IMPLEMENTATION_WORKTREE HEAD == CANDIDATE_SHA. It does not verify the branch ref that backs the PR. If that ref moved, line 136 can record Current branch head == accepted CANDIDATE_SHA while the PR contains another commit. Compare the actual PR branch head with CANDIDATE_SHA before emitting this equality.

Proposed wording

-Final acceptance emits an immutable Final Report snapshot:
+After verifying that the PR branch head equals the accepted CANDIDATE_SHA, final acceptance emits an immutable Final Report snapshot:

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	### Post-acceptance PR handoff (non-gating)
	Final acceptance emits an immutable Final Report snapshot: `Pipeline-reviewed head == Current branch head == accepted CANDIDATE_SHA`, `Pipeline status: current`, and `Current-head review: none`. Do not alter or replace that snapshot, the accepted candidate SHA, or any canonical receipt evidence after acceptance.
	### Post-acceptance PR handoff (non-gating)
	After verifying that the PR branch head equals the accepted CANDIDATE_SHA, final acceptance emits an immutable Final Report snapshot: `Pipeline-reviewed head == Current branch head == accepted CANDIDATE_SHA`, `Pipeline status: current`, and `Current-head review: none`. Do not alter or replace that snapshot, the accepted candidate SHA, or any canonical receipt evidence after acceptance.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.claude/skills/engine-implementer/SKILL.md around lines 134 - 136, Before
emitting the immutable Final Report snapshot in the Post-acceptance PR handoff,
verify that the actual branch ref backing the PR still points to CANDIDATE_SHA,
in addition to the existing IMPLEMENTATION_WORKTREE HEAD check. Record the
equality only when both references match the accepted candidate, preserving the
existing snapshot and receipt evidence behavior.