refactor(engine): type the captured child-boundary stack depth - #7515
Merged
matthewevans merged 1 commit intoAug 17, 2026
Merged
Conversation
Close FrameVec::slot_at_captured_depth, the last bare-`usize` door into resolution-frame addressing, deferred by #7489. ChildStackDepth is an opaque newtype whose tuple field is private to `frame_vec`, so `resolution` -- its parent module -- cannot construct one. A `usize` from a scan still compiles and now has nowhere to go: the only mint is FrameVec::capture_depth, which reads the stack's own length. Threads the type through 15 capture origins, 8 GameState wrappers, 6 ResolutionStack doors, 5 park_* helper params, 9 Ord comparison reads and 3 ResolutionStackError fields. No serialized type is affected. The structural guard gains four conditions built on a balanced-paren signature extractor, so a second bare-`usize` parameter in frame_vec.rs fails CI even when it hides behind a closure or a generic parameter.
matthewevans
enabled auto-merge
August 17, 2026 14:01
|
Generated for head Parse changes introduced by this PR✓ No card-parse changes detected. |
Contributor
|
Caution Review failedAn error occurred during the review process. Please try again later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
matthewevans
deleted the
ship/refactorengine-type-the-captured-child-boundary
branch
August 17, 2026 14:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close FrameVec::slot_at_captured_depth, the last bare-
usizedoor intoresolution-frame addressing, deferred by #7489.
ChildStackDepth is an opaque newtype whose tuple field is private to
frame_vec, soresolution-- its parent module -- cannot construct one.A
usizefrom a scan still compiles and now has nowhere to go: the onlymint is FrameVec::capture_depth, which reads the stack's own length.
Threads the type through 15 capture origins, 8 GameState wrappers, 6
ResolutionStack doors, 5 park_* helper params, 9 Ord comparison reads and
3 ResolutionStackError fields. No serialized type is affected.
The structural guard gains four conditions built on a balanced-paren
signature extractor, so a second bare-
usizeparameter in frame_vec.rsfails CI even when it hides behind a closure or a generic parameter.
Rebase note. Cherry-picked onto an
origin/mainthat had advanced 9 commits past the reviewed base (a8244e73). One conflict, inchange_zone.rs, where the reviewed commit changed the depth-capture line and upstream (#7496) changed the adjacent call line toexecute_zone_move_with_terminal_and_controller. Resolved keep-both. The resolved diff's added/removed lines are byte-identical to the reviewed diff (+337/-116, 11 files); only surrounding context moved. The boundary guard passes on the rebased tree.