Skip to content

Add docker-keel. - #1

Merged
grayside merged 2 commits into
masterfrom
keel
Sep 11, 2017
Merged

Add docker-keel.#1
grayside merged 2 commits into
masterfrom
keel

Conversation

@grayside

Copy link
Copy Markdown
Contributor

Here's a first cut at a CLI base image. The build containers would be rebased onto this.

@grayside
grayside requested review from febbraro and tekante August 31, 2017 23:48
Comment thread Dockerfile Outdated
# https://git-scm.com/docs/git-config#git-config-corepreloadIndex
RUN git config --global core.preloadindex true

# Run the s6-based init.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the comment, we are not using s6

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected the comment and added customization instructions.

@febbraro

Copy link
Copy Markdown
Member

How would outrigger/build handle it's nvm stuff? Would it simply override the /init script with it's own entirely (adding in the nvm parts?)

if [ -e ~/.bash_history ]; then
rm -f ~/.bash_history
fi
ln -sf $TRIGGER_DIR/.bash_history ~/.bash_history

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider expanding this to all of the .bash items in the home directory? We'd likely want to copy over .bash_profile and .bashrc if they didn't exist in $TRIGGER_DIR rather than just link like we can with .bash_history.

Specifically I've found that I desire this when working with things like Acquia's BLT toolset which sets up a blt alias in .bash_profile as an alternative to PATH manipulations to get vendor/bin pulled in.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes a lot of sense. That seems like something we should do as a follow-up.

@grayside

grayside commented Sep 2, 2017

Copy link
Copy Markdown
Contributor Author

How would outrigger/build handle it's nvm stuff? Would it simply override the /init script with it's own entirely (adding in the nvm parts?)

That's the current approach, which isn't great but works. Do you think we should get fancier? E.g., have a directory we autoload scripts from?

@febbraro

febbraro commented Sep 5, 2017

Copy link
Copy Markdown
Member

I don't think we need fancy right now.

@grayside
grayside merged commit e05b844 into master Sep 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants