Upgrades to 'grunt help' #145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test failure is the result of github's present instability. Will trigger a re-test later. |
Collaborator
|
@grayside The Travis test is now fine, but when I tried |
Contributor
Author
|
I recall seeing that bug during development but it does not currently reproduce. Could you give me the output of --stack? |
arithmetric
force-pushed
the
task/global-options
branch
from
1876b6f to
dd40ad1
Compare
Collaborator
|
I added I found that this error could be avoided by removing the "gruntHelp.initTasks" routine from the help process queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds greater complexity and reliance on the internals of the
grunt --helpsystem. However, that code seems pretty stable and changes are likely to be along the line of deprecating some of our changes here. I've come to the conclusion that the better experience is worth the code debt.I copied the output to a fancy gist to facilitate review.
Fixes #65