Run Behat with process env vars #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…addition to ones added by the Behat task.
Contributor
|
Looks good, however is it worth considering whether this should be a bit of "magic" configuration as invented for https://github.com/phase2/grunt-drupal-tasks/pull/166/files. The main difference is you need to be more explicit about env vars of interest, but as a side benefit it provides a mechanism for these values to be set programmatically in project Gruntfile.js. |
Collaborator
Author
|
@grayside That may be worth considering in a future version. Unless there are reasons to think this causes unexpected and bad consequences, we should get this in as a bug fix/usability enhancement and roll a patch release. |
grayside
added a commit
that referenced
this pull request
Jun 23, 2015
Configure Behat to run with access to all environment variables.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that Behat is run with the process's environment variables in addition to ones added by the Behat task.
@peterschuelke reported an issue where Behat failed to run through Grunt Drupal Tasks with the command:
/bin/sh -c vendor/bin/behat -c ./test/behat.yml --tags ~@wip ././test/features/dashboard.featurebut could be run manually with:vendor/bin/behat -c ./test/behat.yml --tags ~@wip ././test/features/dashboard.feature. Another environment had an issue running Behat where it reported php not being found.After applying this patch, Behat was able to run through Grunt Drupal Tasks using the 'sh -c' shell wrapper.