Skip to content

Web pricing UI and Nemotron provider data fixes#415

Merged
DanielButler1 merged 2 commits into
mainfrom
pr/internal-pricing-ui-nemotron-credits-20260429
Apr 29, 2026
Merged

Web pricing UI and Nemotron provider data fixes#415
DanielButler1 merged 2 commits into
mainfrom
pr/internal-pricing-ui-nemotron-credits-20260429

Conversation

@DanielButler1

@DanielButler1 DanielButler1 commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • group the internal model pricing editor by provider and reduce duplicate discount UI on provider cards
  • add missing-performance explainers for blank latency and throughput values
  • improve internal credits admin handling so unused promo codes can be deleted or safely reused without surfacing raw duplicate-key errors
  • remove Fireworks from Nemotron 3 Nano Omni serverless coverage and add GMI Cloud / Nebius Token Factory pricing data

Verification

  • pnpm validate:data
  • pnpm validate:pricing
  • targeted TypeScript program check for the edited internal credits and pricing UI files

Summary by CodeRabbit

  • New Features

    • Added ability to delete promo codes with confirmation dialogs
    • Pricing rules now organized by provider for better navigation
    • Discount countdown badges displayed on provider cards
    • Contextual help added for missing performance metrics
  • Bug Fixes

    • Improved handling when creating duplicate promo codes
  • Chores

    • Updated model availability: Nemotron model removed from DeepInfra and Fireworks; added pricing support for GMICloud and Nebius providers

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@DanielButler1 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 52 minutes and 46 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b703cd51-6c18-4c5d-9f91-5378dfaa9bc4

📥 Commits

Reviewing files that changed from the base of the PR and between e9772bc and 4174f0c.

📒 Files selected for processing (1)
  • packages/data/catalog/src/data/.import-state.json
📝 Walkthrough

Walkthrough

This pull request adds delete functionality for credit grants with validation, reorganizes pricing rules UI to group by provider across multiple components, enhances provider card displays with discount indicators and missing metric handling, simplifies pricing footer rendering, and updates API provider catalogs with new pricing configurations while removing a model.

Changes

Cohort / File(s) Summary
Credit Grant Management
apps/web/src/app/(dashboard)/internal/credits/CreditGrantEditDialog.tsx, apps/web/src/app/(dashboard)/internal/credits/actions.ts
Adds delete capability for promo codes with isDeleting state and confirmation dialog. New deleteCreditGrantAction prevents deletion if redemptions exist. Enhanced createCreditGrantAction handles duplicate codes by updating existing grants with zero redemptions or blocking reuse.
Pricing UI Reorganization
apps/web/src/app/(dashboard)/internal/data/models/new/NewModelForm.tsx, apps/web/src/components/(data)/model/edit/tabs/PricingTab.tsx
Refactors pricing rules to group by provider_id with sorted display and provider-scoped row/rule additions. Bundle actions moved from global header to per-provider sections; UI shows rule counts and provider-specific "Add rule" buttons.
Provider Card Enhancements
apps/web/src/components/(data)/model/pricing/ProviderCard.tsx, apps/web/src/components/(data)/model/pricing/sections.tsx
Aggregates discount end dates across pricing sources and displays countdown badges or live-count messages. Replaces placeholder "--" for missing performance metrics (Latency, Throughput) with contextual tooltips/popovers. Removes discount countdown from footer, showing only base price crossed out.
API Catalog Updates
packages/data/catalog/src/data/api_providers/deepinfra/models.json, packages/data/catalog/src/data/api_providers/fireworks/models.json
Removes nvidia/nemotron-3-nano-omni-30b-a3b-reasoning model definitions from DeepInfra and Fireworks providers.
Pricing Data Additions
packages/data/catalog/src/data/pricing/gmicloud/nvidia-nemotron-3-nano-omni-30b-a3b-reasoning/text.generate/pricing.json, packages/data/catalog/src/data/pricing/nebius-token-factory/nvidia-nemotron-3-nano-omni-30b-a3b-reasoning/text.generate/pricing.json
Introduces new pricing configurations for nvidia/nemotron-3-nano-omni-30b-a3b-reasoning under gmicloud and nebius providers with token-based metering and USD pricing.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested labels

codex

Poem

🐰 Our credits now safely delete with grace,
Pricing grouped by provider in its place,
Discounts count down with emerald gleam,
Metrics display just as they should seem,
Nemotron bids its fond farewell,
While nebius and gmicloud ring the bell! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: web pricing UI improvements and Nemotron provider data modifications are the primary focus across all affected files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch pr/internal-pricing-ui-nemotron-credits-20260429

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 52 minutes and 46 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@DanielButler1 DanielButler1 merged commit b27872e into main Apr 29, 2026
31 checks passed
@DanielButler1 DanielButler1 deleted the pr/internal-pricing-ui-nemotron-credits-20260429 branch April 29, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant