fix(ci): nightly-E2E grün + Dependabot + Action-Versionen bumpen - #13
Merged
Conversation
Die nightly-E2E (e2e.yml) war seit Erstellung bei JEDEM Lauf rot (17 passed / 12 failed). Zwei Ursachen behoben: - Onboarding-Welcome-Modal-Overlay fing Klicks ab (Reset-All, Slider, Masken, Logout) -> 30s-Timeouts in editor/login/screenshots.spec. Fix: beforeEach setzt `lumen.onboarding.v1=dismissed` + clearCookies, analog zu admin/feedback.spec. - Marketplace-Seed lud ein PNG hoch, Backend verlangt fuer oeffentliche Preset-Previews aber JPEG (presets.py) + prueft Magic-Bytes (images.py) -> 400/415. Fix: uploadTinyImage nutzt jetzt ein valides 1x1-JPEG (image/jpeg, ff d8 ff ...). Zusaetzlich: - screenshots.spec ist ein Doku-Generator, kein CI-Test -> hinter LUMEN_SCREENSHOTS=1 gegated (skippt im nightly). - playwright.config: html-Reporter ergaenzt, damit der Artifact-Upload (frontend/playwright-report/) tatsaechlich Inhalt hat. - .github/dependabot.yml: npm (frontend), pip (backend), github-actions -- woechentlich, minor+patch gruppiert. - Action-Versionen gebumpt (Node-20-Deprecation): checkout v5, setup-node v6, setup-python v6, pnpm/action-setup v6, upload-artifact v5. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warum
Die nightly-E2E (
e2e.yml) war seit Erstellung bei jedem Lauf rot — 27+ Runs in Folge, nie grün (zuletzt 17 passed / 12 failed). Außerdem fehlte Dependabot komplett und alle Actions liefen auf dem deprecateten Node 20.Ursachen & Fixes
1. Onboarding-Overlay (7× Editor + Logout + Screenshots) — das Welcome-Modal triggert beim ersten
/editor-Render eines frischen Users und fängt alle Klicks ab (editor-reset-all, Slider, Masken, Logout) → 30s-Timeouts. Fix:beforeEachsetztlumen.onboarding.v1=dismissed+clearCookies(gleiches Muster wieadmin/feedback.spec).2. Marketplace-Seed (3×) —
uploadTinyImagelud ein PNG, das Backend verlangt für öffentliche Preset-Previews aber JPEG (presets.py) und prüft die Magic-Bytes (images.py) →400/415. Fix: valides 1×1-JPEG.Außerdem
screenshots.specist ein Doku-Generator, kein CI-Test → hinterLUMEN_SCREENSHOTS=1gegated (skippt im nightly).playwright.config:html-Reporter ergänzt — der Artifact-Upload hatte bisher nie Inhalt (nurlist-Reporter, keinplaywright-report/)..github/dependabot.yml: npm (/frontend), pip (/backend), github-actions — wöchentlich, minor+patch gruppiert.Verifiziert
YAML-Parse ✓ ·
tsc -b --noEmit✓ · Playwright--list(alle 36 Specs parsen) ✓ · Latest-Tags der Actions per GitHub-API geprüft ✓. Echter E2E-Lauf viaworkflow_dispatchauf diesem Branch (siehe Checks).🤖 Generated with Claude Code