Conversation
Supporting infra for phoenix-pro's new "Claude Code CLI" mode. - Terminal/main.js: export getNodeConnector() so another extension can spawn its own TerminalInstance against the shared phoenix_terminal connector instead of registering a second one (a connector id can only be registered once per side). - TerminalInstance.js: spawn() now accepts env overrides, passed through to the existing createTerminal peer call. Theme resolution (_getThemeFromCSS) now reads --terminal-* off the instance's own container instead of always querying the global .terminal-panel-container singleton — that singleton exists in the DOM even when the bottom Terminal panel is never opened, and is light/dark-theme-aware, which was flipping an embedded terminal elsewhere to a white background whenever the app was in light theme. - strings.js: new AI_CHAT_MODE_*/AI_CHAT_CLI_* strings for the mode dropdown and the CLI session's confirm/stale-project banner text. - Extn-AIChatPanel.less: mode dropdown + per-mode header visibility, the embedded terminal's layout and fixed-dark color palette (the AI sidebar is always-dark regardless of app theme), and the stale-project banner styled as a dark elevation-matched card with an amber accent stripe and Phoenix's real .btn.btn-primary, not a one-off alert box.
Was just "This CLI session..." — inconsistent with the New-button confirm dialog, which already says "the running Claude Code CLI session".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting infra for phoenix-pro's new "Claude Code CLI" mode.