fix: resolve push approval signal path in git worktrees - #18
Merged
Conversation
Use `git rev-parse --show-toplevel` instead of `$CLAUDE_PROJECT_DIR` to locate the push-approved signal file. This ensures the hook and the review-code skill agree on the signal path regardless of whether the push originates from the main repo or a worktree. Closes #17 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git rev-parse --show-toplevelinstead of$CLAUDE_PROJECT_DIRto locate the push-approved signal file incheck-git-push.shreview-codeskill to write the signal using the same git-toplevel pathCloses #17
Test plan
/review-code, approve, thengit push— should succeed/review-code, approve, thengit push— should now succeed (was blocked before)🤖 Generated with Claude Code