Conversation
- InkStroke - InputFieldValuesEnum - InputFieldsEnum - SearchCriteriaEnum
rkrenn
requested review from
01hasenberger,
Jensrib,
SigridDeller,
TschapellerB,
codonAG2 and
ultchagen
Closed
Collaborator
Author
|
@CodeRabbit review |
Contributor
✅ Actions performedReview triggered.
|
Contributor
|
Caution Review failedThe pull request is closed. WalkthroughUpdates CI workflows and scripts, refactors Selenium testing to Maven/TestNG with new helpers, introduces email reporting, adds utility classes (MIME detection, zipping, randomization, ink strokes), migrates MIME type logic from ExecUtil to CommonUtil, adjusts Tomcat setup, updates POMs, and adds comprehensive Selenium tests and Spring test configuration. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions
participant VM as Runner VM
participant Tomcat as Tomcat9 Service
participant DB as PostgreSQL
participant App as CTMS App
participant Tests as Maven Surefire Tests
participant Mail as SMTP
GH->>VM: Checkout repo (actions/checkout@v3)
GH->>VM: Setup JDK, cache Maven
GH->>VM: Build (mvn install -DskipTests --no-transfer-progress)
GH->>VM: Init DB (init_database.sh via sudo -E)
GH->>VM: Setup Tomcat (setup_tomcat.sh)
VM->>Tomcat: systemctl daemon-reload + start
GH->>VM: Load demo data (dbtool.sh -ldd -f)
GH->>Tests: run_selenium_test.sh (mvn surefire:test with -D props)
Tests->>App: UI automation (ChromeDriver)
Tests-->>Mail: Send report email (optional, via JavaMail)
sequenceDiagram
autonumber
participant Test as SeleniumTestBase
participant Spring as Spring Context
participant Reporter as CustomReport
participant Email as ReportEmailSender
participant SMTP as Mail Server
Test->>Spring: load applicationContextTest.xml
Test->>Test: execute @Test methods
Test->>Reporter: aggregate results
Test->>Email: add attachments (HTML/PDF, ZIP)
alt recipients present
Email->>SMTP: send(subject, multipart)
else no recipients
Email-->>Test: skip sending
end
sequenceDiagram
autonumber
participant DDP as DemoDataProvider
participant Rand as Random
participant Ink as InkStroke
participant Util as CommonUtil
DDP->>Rand: getRandomDate/Boolean/Element/Long/Float
DDP->>Ink: new InkStroke(color, path, value)
DDP->>Util: getMimeType(file|bytes)
DDP->>DDP: createSketchField/addInkRegions (using InkStroke)
Estimated code review effort🎯 5 (Critical) | ⏱️ ~120 minutes Possibly related PRs
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.38.6)common/src/main/java/org/phoenixctms/ctsms/util/CommonUtil.javacore/src/exec/java/org/phoenixctms/ctsms/executable/DemoDataProvider.java📜 Recent review detailsConfiguration used: CodeRabbit UI 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (38)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is the commit for our first End-To-End testsuite based on chrome webdriver/selenium server.
it is to be executed automatically by the GitHub java CI (see "Actions" https://github.com/phoenixctms/ctsms/actions).
the first use case covered now is the "Subject Candidate Selection", as raised by AGES Inspektion KPAM 398.
Test outline:
An example of the generated test report PDF is attached below. It represent the documentation mandatory for software validation in regulated environments.
Proband Tests.pdf
Feel free to contact us if you need these test report documents as well.
Summary by CodeRabbit