Skip to content

debian12 github ci runner adjustments#338

Merged
rkrenn merged 25 commits intomasterfrom
tomcat10
Dec 26, 2024
Merged

debian12 github ci runner adjustments#338
rkrenn merged 25 commits intomasterfrom
tomcat10

Conversation

@rkrenn
Copy link
Copy Markdown
Collaborator

@rkrenn rkrenn commented Dec 22, 2024

Summary by CodeRabbit

  • Chores

    • Updated CI to deploy on Tomcat 10 with automated WAR migration.
    • Standardized Java runtime options and activated required environment variables.
    • Adjusted database setup to target PostgreSQL 15 configuration.
    • Streamlined DB tool invocation for reliability.
  • Tests

    • Enhanced Selenium workflow with consistent Java module options and cleaner logging.
    • Simplified test run steps and improved error log visibility during CI runs.

@rkrenn rkrenn linked an issue Dec 25, 2024 that may be closed by this pull request
@rkrenn rkrenn merged commit b98792b into master Dec 26, 2024
@rkrenn
Copy link
Copy Markdown
Collaborator Author

rkrenn commented Aug 18, 2025

@CodeRabbit full review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 18, 2025

✅ Actions performed

Full review triggered.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 18, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Enables CTSMS_PROPERTIES and CTSMS_JAVA in CI scripts, adjusts Java invocation order and JDK add-opens, updates PostgreSQL config path to version 15, introduces a Tomcat 10 setup/deploy script with Jakarta EE migration, updates the CI pipeline to use it, tweaks a SQL qx delimiter, and adds a new Jersey WebComponent class.

Changes

Cohort / File(s) Summary
CI env and Java options
.github/workflows/dbtool.sh, .github/workflows/run_selenium_test.sh
Un-comment CTSMS_PROPERTIES and CTSMS_JAVA; reorder Java flags; add/export JDK_JAVA_OPTIONS with --add-opens; adjust logging in selenium script.
Database setup
/.github/workflows/setup_database.sh
Update PostgreSQL config path from 14 to 15 in sed edits.
Tomcat 10 setup and CI pipeline
/.github/workflows/setup_tomcat10.sh, .github/workflows/test.yml
Add Tomcat 10 setup/deploy script with Jakarta EE migration; switch CI to use it; minor step renames; remove inline CTSMS_* env exports in a step.
DB tool SQL invocation
core/db/dbtool.sql
Change Perl qx execution delimiter from qx $cmd to qx!$cmd! without altering logic.
Jersey Web component
web/src/main/java/com/sun/jersey/spi/container/servlet/WebComponent.java
Add new WebComponent implementing ContainerListener; exposes constants, constructors, lifecycle methods, request dispatching, and configuration handling.

Sequence Diagram(s)

sequenceDiagram
  actor Client
  participant SC as Servlet Container
  participant WC as WebComponent
  participant WA as WebApplication
  participant R as Resource

  Client->>SC: HTTP request
  SC->>WC: service(baseUri, requestUri, req, resp)
  WC->>WC: Build ContainerRequest + SecurityContext
  WC->>WA: handle(ContainerRequest, ResponseWriter)
  WA->>R: Dispatch to matched resource
  R-->>WA: Response (status, headers, entity)
  WA-->>WC: Write via ContainerResponseWriter
  WC-->>SC: Status code
  SC-->>Client: HTTP response
Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

A rabbit taps CI with gentle thumps,
Tomcat 10 now warms and jumps.
Postgres 15 hums in tune,
Jersey’s WebComponent greets the moon.
Flags re-ordered, doors flung wide—
Add-opens let the threads now glide.
Deploy, migrate—then hop with pride! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 61c279b and 6ac4f84.

⛔ Files ignored due to path filters (1)
  • .github/workflows/jakartaee-migration-1.0.8-bin.tar.gz is excluded by !**/*.gz
📒 Files selected for processing (7)
  • .github/workflows/dbtool.sh (1 hunks)
  • .github/workflows/run_selenium_test.sh (2 hunks)
  • .github/workflows/setup_database.sh (1 hunks)
  • .github/workflows/setup_tomcat10.sh (1 hunks)
  • .github/workflows/test.yml (2 hunks)
  • core/db/dbtool.sql (1 hunks)
  • web/src/main/java/com/sun/jersey/spi/container/servlet/WebComponent.java (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch tomcat10

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test with debian 12

1 participant