Load cache manifest from specified application - #3618
Merged
Conversation
Contributor
Author
|
Did someone find the time to take a peek at this PR and give some feedback, that would be nice :) |
Member
|
❤️ 💚 💙 💛 💜 |
chrismccord
pushed a commit
that referenced
this pull request
Jan 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within my current Umbrella project, I have multiple applications sharing the same assets. That's why I've created an "empty" application only containing the assets and the cache manifest. Configuring the correct app was easy for
Plug.Staticthrough the:fromoption. But the:cache_static_manifestoption could only use a directory within the app itself.This PR adds the option to define the application from where the path to the cache manifest must be resolved in a similar fashion as the
Plug.Staticoption. Also a normal file path still works so no breaking backwards compatibility.