Fix EA breathy#347
Merged
bambooforest merged 3 commits intophoible:masterfrom Mar 21, 2022
Merged
Conversation
Contributor
|
Problem of duplicated feature vectors also noted in #352 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #346
Also actually addresses #192 (though perhaps not completely; I didn't check every line), unlike #198 which auto-closed #192 when it probably shouldn't have.
Also adds a couple more tests: one to make sure feature vector assignment is consistent (e.g.,
[h]always has the same features across all inventories) and to look for non-distinct feature vectors within an inventory. That latter test is expected to fail, but it will make it way easier to fix the problems once that test is in place.