Segment fixes for 1284 and 1927 as found by the DR algorithm#356
Merged
drammock merged 4 commits intophoible:masterfrom Jan 30, 2023
Merged
Segment fixes for 1284 and 1927 as found by the DR algorithm#356drammock merged 4 commits intophoible:masterfrom
drammock merged 4 commits intophoible:masterfrom
Conversation
drammock
reviewed
Jan 3, 2023
Co-authored-by: Daniel McCloy <dan@mccloy.info>
Contributor
Author
Member
|
ok. Just a heads up to (usually) not do that with open PRs. In this case (merged PR) it should be fine, though in this case it's equivalent to merging in Is this ready for merge then? |
Contributor
Author
|
Thanks for the heads up. Yes, it's ready to go. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a mistake in Inventory ID 1284 (Mada):
https://phoible.org/inventories/view/1284
and changes eʲ to e (as per the grammar) in the raw data file:
https://github.com/phoible/dev/blob/master/raw-data/PH/gm-afr-inventories.tsv#L1977-L1978
This PR also fixes segments in Inventory ID 1927 (Mỹky):
https://phoible.org/inventories/view/1927
originally from SAPHON source, raw data file:
https://github.com/phoible/dev/blob/master/raw-data/SAPHON/saphon20121031.tsv#L129
and removes the segments (õʲ, aʲ, oʲ) as they do not appear in the original source:
https://linguistics.berkeley.edu/saphon/en/inv/Irantxe.html