Skip to content

Segment fixes for 1284 and 1927 as found by the DR algorithm#356

Merged
drammock merged 4 commits intophoible:masterfrom
bambooforest:dr-fixes
Jan 30, 2023
Merged

Segment fixes for 1284 and 1927 as found by the DR algorithm#356
drammock merged 4 commits intophoible:masterfrom
bambooforest:dr-fixes

Conversation

@bambooforest
Copy link
Copy Markdown
Contributor

@bambooforest bambooforest commented Dec 30, 2022

This PR fixes a mistake in Inventory ID 1284 (Mada):

https://phoible.org/inventories/view/1284

and changes eʲ to e (as per the grammar) in the raw data file:

https://github.com/phoible/dev/blob/master/raw-data/PH/gm-afr-inventories.tsv#L1977-L1978

This PR also fixes segments in Inventory ID 1927 (Mỹky):

https://phoible.org/inventories/view/1927

originally from SAPHON source, raw data file:

https://github.com/phoible/dev/blob/master/raw-data/SAPHON/saphon20121031.tsv#L129

and removes the segments (õʲ, aʲ, oʲ) as they do not appear in the original source:

https://linguistics.berkeley.edu/saphon/en/inv/Irantxe.html

@bambooforest bambooforest changed the title dr fixes Segment fixes for 1284 and 1927 as found by the DR algorithm Dec 31, 2022
Comment thread raw-data/PH/gm-afr-inventories.tsv
Comment thread raw-data/SAPHON/saphon20121031.tsv
@bambooforest
Copy link
Copy Markdown
Contributor Author

bambooforest commented Jan 29, 2023

@drammock -- had to merge in your previous PR (#358) and regen the phoible csv file.

@drammock
Copy link
Copy Markdown
Member

ok. Just a heads up to (usually) not do that with open PRs. In this case (merged PR) it should be fine, though in this case it's equivalent to merging in main (which is pretty much always OK/good to do if your PR branch is behind main).

Is this ready for merge then?

@bambooforest
Copy link
Copy Markdown
Contributor Author

Thanks for the heads up. Yes, it's ready to go.

@drammock drammock merged commit 3f1e21f into phoible:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants