Use advanced Bash in entrypoint #1
Conversation
| eval "$command_string" | ||
| Get_command() | ||
| { | ||
| echo -n "phpstan --no-interaction --no-progress ${action_command}" |
There was a problem hiding this comment.
empty action_command (and action_args and action_path below) cause an extra space
There was a problem hiding this comment.
AFAIK only action_args is allowed to be empty...
|
We don't have a test :( |
|
Please consider running PHPStan in CI. |
|
Hi @szepeviktor , Thank you for your contribution. It looks like there are quite a few changes you're suggesting in this PR. Please could you help me understand the main benefit of the change, so I can review it later today? Thanks, |
|
I've rewritten the entrypoint from a House of Copy-Paste to a single Bash function. That is all. You can see the action options in the for loop.
|
|
House of Copy-Paste - that's a new one to me 😄 Thanks, I'm sure this will improve matters greatly. I am a fan of starting projects like this with the least code, then refactoring over time. This looks like a solid refactor, so I will merge once I've tested properly. |
2 participants
I know - I know - this does not look like a script.