Skip to content

Bump minimal version of "phpunit-bridge"#111

Merged
Nyholm merged 2 commits intophp-cache:masterfrom
jderusse:patch-1
Oct 31, 2020
Merged

Bump minimal version of "phpunit-bridge"#111
Nyholm merged 2 commits intophp-cache:masterfrom
jderusse:patch-1

Conversation

@jderusse
Copy link
Copy Markdown
Contributor

@jderusse jderusse commented Oct 30, 2020

The PR #107 break other projects (like symfony: https://travis-ci.com/github/symfony/symfony/jobs/422680568)

The issue is: when installing dependencies with flag prefer-lowest, composer pick an old buggy version of phpunit-bridge (symfony's bug actually)

This PR bump the minimal version to 5.1 which has the same requirements than 4.4 (https://packagist.org/packages/symfony/phpunit-bridge#5.1.x-dev)

@jderusse jderusse changed the title Move "phpunit-bridge" to "require-dev" section - Revert #107 Bump minimal version of "phpunit-bridge" Oct 30, 2020
@Nyholm Nyholm merged commit 9f1ef69 into php-cache:master Oct 31, 2020
@jderusse
Copy link
Copy Markdown
Contributor Author

jderusse commented Oct 31, 2020

Hmm... sadly, this does not work.... https://travis-ci.com/github/symfony/symfony/jobs/423288016

PHP Fatal error: Uncaught Error: Call to undefined method Symfony\Bridge\PhpUnit\DeprecationErrorHandler\Configuration::isGeneratingBaseline() in /home/travis/build/symfony/symfony/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php:213
Stack trace:
#0 [internal function]: Symfony\Bridge\PhpUnit\DeprecationErrorHandler->Symfony\Bridge\PhpUnit{closure}()
#1 {main}
thrown in /home/travis/build/symfony/symfony/vendor/symfony/phpunit-bridge/DeprecationErrorHandler.php on line 213
Fatal error: Cannot decl

When user use another instance of phpunit-bridge (think global install, or mono-repo), it conflicts with the one installed in vendors.

It could work only if both instances are exactly the same, or the project stop using it own instance of phpunit-bridge

Any idea how fix this.... @nicolas-grekas

@nicolas-grekas
Copy link
Copy Markdown
Collaborator

we should move this back to require-dev and add a note in the README that this should run with the bridge

@jderusse
Copy link
Copy Markdown
Contributor Author

we should move this back to require-dev and add a note in the README that this should run with the bridge

What's about #112 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants