fix: match dtor function signatures to silence UBSan function-type check#52
Merged
Conversation
Destructor functions stored in hash/llist dtor slots were defined with typed parameters and cast to the generic void(*)(void*) slot type. UBSan's -fsanitize=function flags calls through a mismatched pointer as undefined behavior, aborting in post-deactivate during request shutdown and breaking dbgp tests downstream. Change the dtors to take void* and cast internally so the pointer type matches the callee's real signature; drop the now-unnecessary casts at registration sites. Wrap zend_string_release in a local dtor since its signature is fixed.
pronskiy
force-pushed
the
fix/asan-ubsan-issues
branch
from
April 15, 2026 14:05
745c431 to
7dfa442
Compare
pronskiy
marked this pull request as draft
April 15, 2026 14:07
pronskiy
marked this pull request as ready for review
April 15, 2026 16:40
carlos-granados
approved these changes
Apr 15, 2026
carlos-granados
left a comment
carlos-granados
left a comment
Collaborator
There was a problem hiding this comment.
These seem to be changes only made to please the tool but I guess they are harmless, let's go ahead with them
Member
Author
|
Yeah, i tend to agree. This will also introduce unnecessary variance with Xdebug |
The dtor registration pattern (casting typed destructors to the generic xdebug hash/llist dtor slot types) is shared with upstream Xdebug and works correctly on all supported platforms, but trips UBSan's -fsanitize=function indirect-call type check. Suppress the check at build time rather than diverge from upstream source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
void(*)(void*)hash/llist dtor slot. UBSan's-fsanitize=functionflags this as UB and aborts during request shutdown, cascading into dbgp test failures.void *and cast internally; drop the now-unnecessary casts at registration sites. Wrapzend_string_releasein a local dtor since its signature is fixed.Fixes #50