Urls not urlencoded

[JanPetterMG]

Urls in the Embed\Http\Url class are not urlencoded.

I've stumbled upon lots of UTF-8 characters, witch is not allowed in urls unless encoded.

Version 3.0.5 (latest)
PHP 5.6

[oscarotero]

Can I get some urls? It helps to fix and test

[JanPetterMG]

Quick and dirty code to reproduce:

use Embed\Embed;
use Embed\Http\DispatcherInterface;
use Embed\Http\Response;
use Embed\Http\Url;

class MyDispatcher implements DispatcherInterface
{
	public function dispatch(Url $url)
	{
		echo $url->__toString() . "<br>\r\n";
		return new Response($url, $url, 200, null, '', [], []);
	}

	public function dispatchImages(array $urls)
	{
		return [];
	}
}

$array = [
	'http://www.innherred.no/kultur/2017/03/25/On-the-road-med-%C3%86-og-Hagen-14499028.ece',
	'http://www.opdalingen.no/kultur/2017/03/26/Aksjetegning-for-%C3%A5-skaffe-hingst-i-Drivdalen-14504810.ece',
	'http://www.smp.no/nyheter/alesundogomland/2017/03/17/Person-p%C3%A5kj%C3%B8rt-p%C3%A5-Flisnes-14465231.ece',
	'http://www.t-a.no/nyheter/2017/03/25/Tr%C3%B8ndelag-klager-mest-over-nedlagte-lensmannskontor-14503303.ece',
	'http://www.fosna-folket.no/gammeldagan/2017/03/26/F%C3%B8dt-uten-armer-en-mester-i-s%C3%B8m-og-broderi-14496650.ece',
];
foreach ($array as $url) {
	Embed::create($url, [], new MyDispatcher());
}

Produces:

http://www.innherred.no/kultur/2017/03/25/On-the-road-med-Æ-og-Hagen-14499028.ece
http://www.opdalingen.no/kultur/2017/03/26/Aksjetegning-for-å-skaffe-hingst-i-Drivdalen-14504810.ece
http://www.smp.no/nyheter/alesundogomland/2017/03/17/Person-påkjørt-på-Flisnes-14465231.ece
http://www.t-a.no/nyheter/2017/03/25/Trøndelag-klager-mest-over-nedlagte-lensmannskontor-14503303.ece
http://www.fosna-folket.no/gammeldagan/2017/03/26/Født-uten-armer-en-mester-i-søm-og-broderi-14496650.ece

While everything is encoded as expected in the demo:

• https://oscarotero.com/embed3/demo/index.php?url=http%3A%2F%2Fwww.innherred.no%2Fkultur%2F2017%2F03%2F25%2FOn-the-road-med-%25C3%2586-og-Hagen-14499028.ece
• https://oscarotero.com/embed3/demo/index.php?url=http%3A%2F%2Fwww.opdalingen.no%2Fkultur%2F2017%2F03%2F26%2FAksjetegning-for-%25C3%25A5-skaffe-hingst-i-Drivdalen-14504810.ece
• https://oscarotero.com/embed3/demo/index.php?url=http%3A%2F%2Fwww.smp.no%2Fnyheter%2Falesundogomland%2F2017%2F03%2F17%2FPerson-p%25C3%25A5kj%25C3%25B8rt-p%25C3%25A5-Flisnes-14465231.ece
• https://oscarotero.com/embed3/demo/index.php?url=http%3A%2F%2Fwww.t-a.no%2Fnyheter%2F2017%2F03%2F25%2FTr%25C3%25B8ndelag-klager-mest-over-nedlagte-lensmannskontor-14503303.ece
• https://oscarotero.com/embed3/demo/index.php?url=http%3A%2F%2Fwww.fosna-folket.no%2Fgammeldagan%2F2017%2F03%2F26%2FF%25C3%25B8dt-uten-armer-en-mester-i-s%25C3%25B8m-og-broderi-14496650.ece

Haven't debugged much, but this is my guess:

1. Input parameter URL gets decoded
2. Internally everything is handled as UTF-8
3. Requested data is encoded when applicable

[oscarotero]

Ok, the url encoding was applied to the directories but not to the filename. It's fixed now.
Thanks.