PHP8 incompatibility

[strarsis]

@oscarotero: Embed doesn't seem to be compatible with PHP8:

Parse error: syntax error, unexpected token "match", expecting "(" in [...]/vendor/embed/embed/src/functions.php on line 119

https://github.com/oscarotero/Embed/blob/45aaeae8636b8a9d4056c8b5f7bb9aebc1b81557/src/functions.php#L119

Edit: match is a reserved keyword in PHP8.x for match expressions, hence the parse error. When the match function is renamed to something else, e.g. match2, the file parses without errors.

PR ready: #394

Note: Travis CI appears to support PHP 8 now, it may be a nice idea to add PHP 8 to .travis.yml so embed is automatically tested on it.

[oscarotero]

Hi, thanks for the PR, it's merged.
Seems like TravisCI fails installing php8 https://travis-ci.org/github/oscarotero/Embed/jobs/737369064

[strarsis]

@oscarotero: Apparently Travis CI treats PHP 8 currently as 'nightly', e.g. https://github.com/doctrine/instantiator/pull/67/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485R10.
https://github.com/oscarotero/Embed/pull/381/files#diff-6ac3f79fc25d95cd1e3d51da53a4b21b939437392578a35ae8cd6d5366ca5485R7 (older PR with merge conflicts).

[oscarotero]

Ah, ok. PHP8 is not released yet (stable version).

[oscarotero]

Released this change in https://github.com/oscarotero/Embed/releases/tag/v4.3.0