Parsed down the URL parameter which earlier allowed XSS on page #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscarotero
added a commit
that referenced
this pull request
Nov 26, 2015
Parsed down the URL parameter which earlier allowed XSS on page
Collaborator
|
Good job. Thank you! |
Contributor
Author
|
:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visit this page before updating the website:
http://oscarotero.com/embed2/demo/index.php?url=%3Cimg%20src=x%20onerror=alert()%3E%20%3Ch1%20style=%22position:absolute;top:0;font-size:100px%22%3EThis%20is%20easily%20defaceable
It shows a message This is easily defaceable. If you disable your inbuilt XSS auditor, (ex-run in firefox), you can even execute arbitrary javascript on the frontend.
I've fixed that by checking if URL is actually a URL or not.