Skip to content

fixing up readme, especially broken example code. #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oscarotero merged 1 commit into from
Feb 1, 2016
Merged

fixing up readme, especially broken example code. #117

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 15 additions & 16 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,12 +90,12 @@ $config = [

'config' => [
'minImageWidth' => 16,
'minImageHeight' => 16,
'imagesBlacklist' => null,
'getBiggerImage' => false,
'getBiggerIcon' => false,
'minImageHeight' => 16,
'imagesBlacklist' => null,
'getBiggerImage' => false,
'getBiggerIcon' => false,
]
]
]
];
```

Expand Down Expand Up @@ -146,11 +146,10 @@ The resolver configuration is defined under the "resolver" key and it has two op
* config: The options passed to the class. If you use the default curl class, the config are the same than the [curl_setopt PHP function](http://php.net/manual/en/function.curl-setopt.php)

```php

// CURL
$config = [
'resolver' => [
'class' => 'Embed\\RequestResolvers\\Curl' // The default resolver used
'class' => 'Embed\\RequestResolvers\\Curl', // The default resolver used

'config' => [
CURLOPT_MAXREDIRS => 20,
Expand Down Expand Up @@ -195,7 +194,7 @@ Like the resolver class, you can provide your own image class (it must implement
//CURL
$config = [
'image' => [
'class' => 'Embed\\ImageInfo\\Curl' //The default imageInfo used
'class' => 'Embed\\ImageInfo\\Curl', //The default imageInfo used

'config' => [
CURLOPT_MAXREDIRS => 20,
Expand Down Expand Up @@ -231,17 +230,17 @@ $config = [

```php
$config = [
'adapter' => [
'config' => [
'minImageWidth' => 16,
'adapter' => [
'config' => [
'minImageWidth' => 16,
'minImageHeight' => 16,
'imagesBlacklist' => [
'http://example.com/full/path/to/image.jpg',
'http?://test.*/*.png/',
'*/bad_image.gif'
]
]
],
]
],
'providers' => [
'oembed' => [
'parameters' => [],
Expand All @@ -260,9 +259,9 @@ $config = [
CURLOPT_MAXREDIRS => 3
]
]
'image' => [
'class' => 'App\\MyImageInfoClass'
]
'image' => [
'class' => 'App\\MyImageInfoClass'
]
];
```

Expand Down