Response constructor phpdoc + minor improvements #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added default value to array $info
Collaborator
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added phpdoc for Response constructor
At least PHPStorm (probably others too) is guessing that
$contentis an array, witch it is not...Cast
$statusCodeasintThis could saved me a lot of debugging, was receiving lots of
InvalidUrlExceptionfor URLs with Status code == 200. Easy to fix internally, but sharing it upstream is probably an even better solution.Added default value
[]of array$infoin the Response constructor.The value isn't used for anything internally, it's just there for optional external usage.