[PSR-6] Renamed "pool" to "cache" for better usability, made naming consistent#361
Closed
webmozart wants to merge 1 commit intophp-fig:masterfrom
Closed
[PSR-6] Renamed "pool" to "cache" for better usability, made naming consistent#361webmozart wants to merge 1 commit intophp-fig:masterfrom
webmozart wants to merge 1 commit intophp-fig:masterfrom
Conversation
|
I agree with all these changes. After recently attempting to build a cache layer based on this PSR, I came to the same conclusions. |
Contributor
|
The naming here was discussed at obscene length in the past. The idea of keeping the "pool" in the name was to make it clear that we were talking about a specific pool, bin, etc, not about the cache driver itself. That was a point of confusion before. (I personally preferred "bin" to "pool", but the consensus on list was to go with pool.) |
Member
|
I am happy with the term Pool. If we thought about changing it to Cache I would have no objections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
Thank you @tedivm for explaining the cache approaches on your blog. I like the proposal.
As an outsider of the cache working group, I would like to bring in some unbiased feedback:
getKey(), butget(). This is a bit weird - IMO the code becomes easier to read ifget()andset()are calledgetValue()andsetValue().getItem()andgetItems(), butdeleteItems()only. I addeddeleteItem()for the sake of completeness.I have some more suggestions which require more discussion however. I'll submit them in a separate PR.
Thanks for your hard work! :)
Cheers,
Bernhard