Removing the delegate lookup feature from PSR-11#854
Conversation
weierophinney
left a comment
There was a problem hiding this comment.
Looks good; I did not see any other spots where the feature is mentioned, and noted that you'd updated heading numbers correctly.
|
Just put 👍 as the message (nothing else). |
I couldn't find that information even in the pullapprove overview or features... Is there a way to make that more obvious in the future, @michaelcullum ? |
|
@weierophinney GH keeps saying they'll open up approvals/reviews on their API, then pullapprove will use that. Until then it's actually regex defined in the repo which is why it's not on pull approve's site. You're welcome to modify it (https://github.com/php-fig/fig-standards/blob/master/.pullapprove.yml#L2) other than that I'm not sure where we could document this although I do try to generally inform people with commit access that it's there when they get given access. |
|
@moufmouf Do you mind resolving the conflicts for this pull request? |
|
@KorvinSzanto Done, conflicts resolved. |
|
As a general note, this will probably require a review period reset so you might want to get this merged ASAP if you are still planning on doing this on FIG 2. |
Following discussion on the mailing list, there seems to be a consensus that the delegate lookup feature (which is actually a design pattern) might be worked on in another PSR (or may be not needed as a PSR at all as it is only a design pattern).