Skip to content

Conversation

@afilina
Copy link
Contributor

@afilina afilina commented Dec 30, 2016

Added filesystem validator that runs from the command-line. #20

Quickly validate your project's compliance by following these steps:

- Install package in your project: `composer require pds/skeleton @dev`
- Run the validator: `./vendor/pds/skeleton/bin/validate`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the validator be exposed by composer in vendor/bin ? This would be more common (it should be renamed to a less generic name to avoid clashes of course)

@stof
Copy link

stof commented Jan 1, 2017

See my issue on the research project about inconsistent behavior of the compliance checker: php-pds/skeleton_research#1

I think this should be solved before shipping a validator in the main package

@pmjones pmjones merged commit 6605a8a into php-pds:1.x Jan 1, 2017
@pmjones
Copy link

pmjones commented Jan 1, 2017

Thanks @afilina .

@stof I wanted to merge this before addressing your good ideas on compliance checking, so there'd be a base to work from. Look for replies in the skeleton_research issues soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants