Use a metapackage for composer #22
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this package does not provide any code and is meant to be required as an indication of adoption, forcing all projects to download it does not make sense. Metapackages cover this case.
|
Nice, I didn't know about this. For those interested, here's the documentation: This is not my project, so it may be not my place to ask, but could you squash the commits, please? Two of the three are nonfunctional. |
Author
|
This PR should be rejected if #21 is meant to be merged though, as it will then bring code. However, I still think that using keywords rather than type to hold |
|
This and other future PDS publications are likely to include code of some sort, so "metapackage" seems inappropriate. As for using keywords instead of the package type: noted, and pondering. :-) |
Author
|
@pmjones you can change the type of package once it starts having code in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this package does not provide any code and is meant to be required as an indication of adoption, forcing all projects to download it does not make sense. Metapackages cover this case.