Skip to content

Conversation

@bocharsky-bw
Copy link
Member

Looks like we have Bing translator.

Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm
Copy link
Member

Nyholm commented Jun 24, 2019

@NullIsNot0 this looks okey, right?

@bocharsky-bw could you rebase so we see that the tests are green?

@NullIsNot0
Copy link
Contributor

Looks ok to me.

@bocharsky-bw
Copy link
Member Author

Thank you for your feedback @NullIsNot0 !

Btw, feel free to "Approve" or "Request changes" even if you're not a part of the organization (yet). You can do it when on "Files changed" tab, see "Review changes" in the top right corner of the page - this will help to understand your opinion on it ;)

@Nyholm
Copy link
Member

Nyholm commented Jun 24, 2019

I’ve sent you an invite. If you want to accept. Feel free to merge this PR

@NullIsNot0 NullIsNot0 merged commit 35d3ecf into master Jun 25, 2019
@Nyholm Nyholm deleted the bocharsky-bw-patch-2 branch June 25, 2019 15:14
@Nyholm
Copy link
Member

Nyholm commented Jun 25, 2019

Awesome!

Thank you @NullIsNot0.
You can use githubs button "squash and merge" to make sure the history looks a little nicer.

@NullIsNot0
Copy link
Contributor

OK, thank you! Next time I'll use that button :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants