Skip to content

Add missing Bing translator #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 25, 2019
Merged

Add missing Bing translator #299

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b83b9e
Add missing Bing translator
bocharsky-bw Mar 14, 2019
f8b3739
Register php_translation.translator_service.bing service
bocharsky-bw Mar 14, 2019
b6afef5
Merge branch 'master' of github.com:php-translation/symfony-bundle in…
bocharsky-bw Jun 24, 2019
3746b43
Fix code style as StyleCI requested
bocharsky-bw Jun 24, 2019
6b291bf
Remove unused namespace
bocharsky-bw Jun 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Command/DeleteObsoleteCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@
*/
class DeleteObsoleteCommand extends Command
{
use BundleTrait, StorageTrait;
use BundleTrait;
use StorageTrait;

protected static $defaultName = 'translation:delete-obsolete';

Expand Down
4 changes: 2 additions & 2 deletions Command/DownloadCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@
use Translation\Bundle\Service\CacheClearer;
use Translation\Bundle\Service\ConfigurationManager;
use Translation\Bundle\Service\StorageManager;
use Translation\Bundle\Model\Configuration;

/**
* @author Tobias Nyholm <tobias.nyholm@gmail.com>
*/
class DownloadCommand extends Command
{
use BundleTrait, StorageTrait;
use BundleTrait;
use StorageTrait;

protected static $defaultName = 'translation:download';

Expand Down
2 changes: 1 addition & 1 deletion DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ private function addAutoTranslateNode(ArrayNodeDefinition $root)
->arrayNode('fallback_translation')
->canBeEnabled()
->children()
->enumNode('service')->values(['google', 'yandex'])->defaultValue('google')->end()
->enumNode('service')->values(['google', 'yandex', 'bing'])->defaultValue('google')->end()
->scalarNode('api_key')->defaultNull()->end()
->end()
->end()
Expand Down
4 changes: 4 additions & 0 deletions Resources/config/auto_translation.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,3 +23,7 @@ services:
php_translation.translator_service.yandex:
class: Translation\Translator\Service\YandexTranslator
arguments: ["%php_translation.translator_service.api_key%"]

php_translation.translator_service.bing:
class: Translation\Translator\Service\BingTranslator
arguments: ["%php_translation.translator_service.api_key%"]